Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP agreement timestamp is a string instead of an object #3278

Closed
matgnt opened this issue Jul 6, 2023 · 5 comments
Closed

DSP agreement timestamp is a string instead of an object #3278

matgnt opened this issue Jul 6, 2023 · 5 comments
Labels
bug_report Suspected bugs, awaiting triage stale Open for x days with no activity triage all new issues awaiting classification

Comments

@matgnt
Copy link

matgnt commented Jul 6, 2023

EDC uses a string timestamp instead of an object.
I opened the discussion here:

International-Data-Spaces-Association/ids-specification#132

Just a head-up. In case this is jsonld related, I also expect this to be profiled as with the other topics here:
International-Data-Spaces-Association/ids-specification#125

meaning, it will be required to be an object like:

"dspace:timestamp": {
      "@value": "2023-01-01T01:00:00Z",
      "@type": "xsd:dateTime"
    }

as it is right now in the DSP spec text and examples.

--
Matthias Binzer

@matgnt matgnt added bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification labels Jul 6, 2023
@jimmarino
Copy link
Contributor

jimmarino commented Jul 6, 2023

I don't think the @type value is required since Json-Ld does not mandate explicitly typing nodes (which would also include strings). During expansion, the @type may be added to the result, see Type Coercion

@matgnt
Copy link
Author

matgnt commented Jul 7, 2023

@jimmarino I think we should have this discussion in the DSP spec issue:
International-Data-Spaces-Association/ids-specification#132

The issue here is meant more as a heads-up, that there is potential that this might change. As mentioned, all examples in DSP spec look different to what EDC delivers right now. And this is probably again an jsonld topic.

@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jul 22, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug_report Suspected bugs, awaiting triage stale Open for x days with no activity triage all new issues awaiting classification
Projects
None yet
Development

No branches or pull requests

2 participants