Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of DspHttpDispatcherDelegate #3344

Closed
ndr-brt opened this issue Jul 31, 2023 · 0 comments · Fixed by #3771
Closed

get rid of DspHttpDispatcherDelegate #3344

ndr-brt opened this issue Jul 31, 2023 · 0 comments · Fixed by #3771
Assignees
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Jul 31, 2023

Feature Request

In the DSP dispatching components we have this "delegate" that takes care of both creating the request and handling the response for the messages through the DSP wire, other than the evident SRP violation, it is designed using abstractions, and this brought in issues in tests (that have an hierarchy themselves) but also it's not easy to change to handle "exceptional cases" (see dataset request in #3342).

A first refactoring work has already been done in #3342 extracting the "create request" behavior, but also the "handle response" could be modeled in a different way, using composition over abstraction.

Which Areas Would Be Affected?

dsp dispatch

Why Is the Feature Desired?

refactoring

@ndr-brt ndr-brt added refactoring Cleaning up code and dependencies dataspace-protocol related to the dataspace protocol labels Jul 31, 2023
@ndr-brt ndr-brt added this to the Milestone 11 milestone Jul 31, 2023
@ndr-brt ndr-brt modified the milestones: Milestone 12, Milestone 13 Nov 15, 2023
@ndr-brt ndr-brt self-assigned this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants