Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsp: add counter party validation to all the TransferProcess DSP incoming messages #3397

Closed
ndr-brt opened this issue Aug 31, 2023 · 0 comments · Fixed by #3402
Closed

dsp: add counter party validation to all the TransferProcess DSP incoming messages #3397

ndr-brt opened this issue Aug 31, 2023 · 0 comments · Fixed by #3402
Assignees
@wolf4ood
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Milestone
Milestone 11

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Aug 31, 2023

Feature Request

Currently we're validating only the TransferRequestMessage because it's the only that really matters, but for consistency we should validate also the counter party id on every other message (start, completion, termination)

Which Areas Would Be Affected?

protocol service

Why Is the Feature Desired?

consistency

Solution Proposal

If possible, provide a (brief!) solution proposal.
@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Aug 31, 2023
@ndr-brt ndr-brt added this to the Milestone 11 milestone Aug 31, 2023
@wolf4ood wolf4ood self-assigned this Aug 31, 2023
@wolf4ood wolf4ood mentioned this issue Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf4ood wolf4ood

Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Milestone
Milestone 11
Development

Successfully merging a pull request may close this issue.

feat: adds counter party validation on all DSP messages wolf4ood/DataSpaceConnector
2 participants
@wolf4ood @ndr-brt