Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: inline DataRequest in TransferProcess #3732

Closed
ndr-brt opened this issue Dec 21, 2023 · 2 comments · Fixed by #4009
Closed

refactor: inline DataRequest in TransferProcess #3732

ndr-brt opened this issue Dec 21, 2023 · 2 comments · Fixed by #4009
Labels
refactoring Cleaning up code and dependencies
Milestone
Backlog

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Dec 21, 2023

Feature Request

the DataRequest value object is a leftover from the old IDS protocol spec, but in fact it does not represent anything in our domain model, so we should "inline" it (moving all its fields in the TransferProcess)

Which Areas Would Be Affected?

transfer

Why Is the Feature Desired?

cleanup

Solution Proposal

first we'll need to change the signatures types of the ResourceManifestGenerator and *ResourceDefinitionGenerator from DataRequest to TransferProcess
@ndr-brt ndr-brt added feature_request New feature request, awaiting triage triage all new issues awaiting classification good first issue Good for newcomers refactoring Cleaning up code and dependencies and removed feature_request New feature request, awaiting triage triage all new issues awaiting classification labels Dec 21, 2023
@ndr-brt ndr-brt mentioned this issue Dec 21, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jan 5, 2024
@ndr-brt ndr-brt removed the stale Open for x days with no activity label Jan 8, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jan 23, 2024
@ndr-brt ndr-brt added this to the Backlog milestone Jan 23, 2024
@ndr-brt ndr-brt removed the stale Open for x days with no activity label Jan 23, 2024
@ndr-brt ndr-brt mentioned this issue Mar 8, 2024
Merged
@ndr-brt ndr-brt removed the good first issue Good for newcomers label Mar 14, 2024
@ndr-brt ndr-brt mentioned this issue Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

refactor: inline DataRequest value object into TransferProcess Think-iT-Labs/edc-connector
1 participant
@ndr-brt