Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token Refactor Step 6: Miscellaneous refactorings #3748

Closed
Tracked by #3743
paullatzelsperger opened this issue Dec 29, 2023 · 1 comment · Fixed by #3773
Closed
Tracked by #3743

Token Refactor Step 6: Miscellaneous refactorings #3748

paullatzelsperger opened this issue Dec 29, 2023 · 1 comment · Fixed by #3773
Labels
refactoring Cleaning up code and dependencies
Milestone
Milestone 13

Comments

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Dec 29, 2023 •
edited
Loading

Feature Request

  • IdentityProviderKeyResolver: use a builder and remove references to IdentityProviderKeyResolverConfiguration
  • TransferDataPlaneCoreExtension: remove privateKeyResolver field (unused)
  • remove PrivateKeyWrapper and PublicKeyWrapper

Which Areas Would Be Affected?

e.g., DPF, CI, build, transfer, etc.

Why Is the Feature Desired?

Are there any requirements?

Solution Proposal

If possible, provide a (brief!) solution proposal.
@paullatzelsperger paullatzelsperger added the refactoring Cleaning up code and dependencies label Dec 29, 2023
@paullatzelsperger paullatzelsperger added this to the Milestone 13 milestone Dec 29, 2023
@paullatzelsperger paullatzelsperger mentioned this issue Dec 29, 2023
Closed
9 tasks
@paullatzelsperger
Copy link
Member Author

the field TransferDataPlaneCoreExtension#privateKeyResolver is actually still needed, because the ConsumerPullDataPlaneProxyResolver needs it to generate access tokens.

@paullatzelsperger paullatzelsperger mentioned this issue Jan 12, 2024
Merged
@paullatzelsperger paullatzelsperger linked a pull request Jan 12, 2024 that will close this issue
refactor: miscellaneous refactorings #3773
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
Milestone 13
Development

Successfully merging a pull request may close this issue.

refactor: miscellaneous refactorings paullatzelsperger/DataSpaceConnector
1 participant
@paullatzelsperger