Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor http dsp modules #4507

Closed
Tracked by #4505
wolf4ood opened this issue Sep 27, 2024 · 0 comments · Fixed by #4514
Closed
Tracked by #4505

Refactor http dsp modules #4507

wolf4ood opened this issue Sep 27, 2024 · 0 comments · Fixed by #4514
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented Sep 27, 2024 •
edited
Loading

Feature Request

We should refactor the current dsp module implementation.

  • DspRequestHandlerImpl and JsonLdRemoteMessageSerializerImpl should rely on the root TypeTransformerRegistry and then fetch the correct ContextTransformerRegistry based on the dsp-api prefix + version extracted from RemoteMessage and DspRequest.

  • For backward compatibility if no version is found the lookup for transformers is dsp-api otherwise will be dsp-api:<version>

Which Areas Would Be Affected?

core dsp

Why Is the Feature Desired?

Are there any requirements?

Solution Proposal

If possible, provide a (brief!) solution proposal.
@wolf4ood wolf4ood added refactoring Cleaning up code and dependencies dataspace-protocol related to the dataspace protocol labels Sep 27, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Sep 27, 2024
@wolf4ood wolf4ood mentioned this issue Sep 27, 2024
Open
12 tasks
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Sep 27, 2024
@wolf4ood wolf4ood mentioned this issue Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: supports multi protocols dsp-http wolf4ood/DataSpaceConnector
1 participant
@wolf4ood