-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add negotiation endpoint api spec examples #3283
feat: add negotiation endpoint api spec examples #3283
Conversation
2544822
to
7418858
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
+ Coverage 65.90% 72.20% +6.29%
==========================================
Files 836 837 +1
Lines 16849 16867 +18
Branches 934 951 +17
==========================================
+ Hits 11105 12178 +1073
+ Misses 5379 4296 -1083
- Partials 365 393 +28
☔ View full report in Codecov by Sentry. |
7418858
to
434735e
Compare
434735e
to
2e66a49
Compare
dc19189
to
05ce287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving based on PR description
05ce287
to
3e0bf57
Compare
What this PR changes/adds
Add negotiation endpoint api spec examples
Why it does that
documentation
Further notes
Dto
s and simplified the object hierarchy without changing the apiManagementApiTypeRegistry
that's like a wrapper around theTypeTransferRegistry
, the first will use the transformers registered on itself and, if not found will rely on the latter (called fallback). This was to permit the co-existance of twoContractNegotiation
toJsonObject
transformers.transfer-core
extension that supersededdsp-transform
(as described in extract atransform-core
module #2883)ApiConfiguration
, because the transformation is something related to the api, needed to map from the serialized data to the domain model one, and every api context could have its own transformation. With this PR we'll have thedsp
context use the standardTypeTransformerRegistry
and themanagement
using the mentionedManagementApiTypeRegistry
, because every context could have a different way of serializing/deserializing domain objects. I guess in the future this could evolve in having also a dsp transformer registry.Linked Issue(s)
Closes #3146
Closes #2883
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.