Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): improve outputting dependencies if they are different #3298

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

If the DEPENDENCIES file is outdated or differs from the generated one in any way, an error is issued and the job fails.
Also, in that case, the contents of the regenerated file are echoed.

Why it does that

improved convenience function

Further notes

  • after this is merged, we should move the dependency-review.yaml job up into the .github repository.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Jul 13, 2023
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@paullatzelsperger paullatzelsperger merged commit caaf554 into eclipse-edc:main Jul 13, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants