Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add agreement endpoints schema examples #3299

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jul 13, 2023

What this PR changes/adds

Add ContractAgreement endpoints schema examples

Why it does that

documentation

Further notes

  • refactored E2E management test a little

Linked Issue(s)

Part of #3146

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added documentation Improvements or additions to documentation enhancement New feature or request api Feature related to the (REST) api labels Jul 13, 2023
@@ -589,7 +589,7 @@ paths:
content:
'*/*':
schema:
$ref: '#/components/schemas/QuerySpecDto'
$ref: '#/components/schemas/QuerySpecSchema'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the openapi.yaml file isn't used for anything anymore, so we should be able to delete it.

@ndr-brt ndr-brt merged commit 578fb6c into eclipse-edc:main Jul 14, 2023
24 checks passed
@ndr-brt ndr-brt deleted the 3146-agreement-api-spec-examples branch July 14, 2023 11:29
bjungs pushed a commit to imec-int/edc that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants