diff --git a/.github/ISSUE_TEMPLATE/adoption_request.md b/.github/ISSUE_TEMPLATE/adoption_request.md deleted file mode 100644 index 4716a10..0000000 --- a/.github/ISSUE_TEMPLATE/adoption_request.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -name: Adoption Request -about: Submit your feature to the project -title: 'Adoption Request' -labels: 'adoption' -assignees: '' - ---- - -# Adoption Request - -_Thank you for wanting to contribute to the project! We are very happy to see the functionalities of the EDC being extended. Providing this open-source is a great opportunity for others with similar requirements and to avoid additional work._ - -_For any details about the guidelines for submitting features, please take a look at the [contribution categories](https://github.com/eclipse-edc/Connector/blob/main/contribution_categories.md)._ - - -## General information - -Please provide some information about your project or code contribution. - -_If you choose to be referenced as a "friend", these will be added to the [known friends list](https://github.com/eclipse-edc/Connector/blob/main/known_friends.md)._ -_If you choose to add your feature as a core EDC component, links to your current code and correlated issues, discussions, and pull requests are of great importance._ - -| Title | Description | Contact | Links -| :--- | :--- | :--- | :--- -| _My awesome project_ | _This is an example._ | _e-mail-address_ | _link to repository, homepage, discussion, etc._ - - -## Adoption level - -Next, please tell us what level of adoption you intend to provide. _(pick only one)_ - -- [ ] Reference a feature as "friend" -- [ ] Incorporate a feature as core EDC component - - - -## Adoption in EDC core - -_If you chose to add your feature as a core EDC component, please answer the following questions._ - -### Why should this contribution be adopted? -_Please argue why this feature must be hosted upstream and be maintained by the EDC core team._ - -### Could it be achieved with existing functionality? If not, why? -_If there is any existing code that can achieve the same thing with little modification, that is usually the preferable way for the EDC core team. We aim to keep the code succinct and want to avoid similar/duplicate code. Make sure you understand the EDC code base well!_ - -### Are there multiple use cases or applications who will benefit from the contribution? -_Basically, we want you to motivate who will use that feature and why, thereby arguing the fact that it is well-suited to be adopted in the core code base. One-off features are better suited to be maintained externally._ - -### Can it be achieved without introducing third-party dependencies? If not, which ones? -_EDC is a platform rather than an application, therefore we are extremely careful when it comes to introducing third party libraries. The reasons are diverse: security, license issues and over all JAR weight, just to mention a few important ones._ - -### Would this feature limit platform independence in any way? If so, how and why? -_Features that do not work well in clustered environments are difficult to adopt, since EDC is designed from the ground up to be stateless and clusterable. Similarly, features, that have dependencies onto certain operating systems are difficult to argue._ - -### Is it going to be a self-contained feature, or would it cut across the entire code base? -_Features that have a large impact on the code base are very complex to thoroughly test, they have a high chance to destabilize the code and require careful inspection. Self-contained features on the other hand are easier to isolate and test._ diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md deleted file mode 100644 index 2645366..0000000 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ /dev/null @@ -1,47 +0,0 @@ ---- -name: Bug Report -about: Create a report to help us improve -title: '' -labels: [ "bug_report", "triage" ] -assignees: '' - ---- - -# Bug Report - -## Describe the Bug - -_A clear and concise description of the bug._ - -### Expected Behavior - -_A clear and concise description of what you expected to happen._ - -### Observed Behavior - -_A clear and concise description of what happened instead._ - -## Steps to Reproduce - -Steps to reproduce the behavior: - -1. Go to '...' -2. Click on '....' -3. Scroll down to '....' -4. See error - -## Context Information - -_Add any other context about the problem here._ - -- Used version [e.g. EDC v1.0.0] -- OS: [e.g. iOS, Windows] -- ... - -## Detailed Description - -_If applicable, add screenshots and logs to help explain your problem._ - -## Possible Implementation - -_You already know the root cause of the erroneous state and how to fix it? Feel free to share your thoughts._ diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml deleted file mode 100644 index 54edf2d..0000000 --- a/.github/ISSUE_TEMPLATE/config.yml +++ /dev/null @@ -1,12 +0,0 @@ ---- -blank_issues_enabled: false -contact_links: - - name: Open up a blank issue - url: https://github.com/eclipse-edc/Connector/issues/new - about: Don’t see your issue here? Open up a blank one - - name: Ask a question or get support - url: https://github.com/eclipse-edc/Connector/discussions/categories/q-a - about: Ask a question or request support for using the Eclipse Dataspace Connector - - name: Take a look at the documentation - url: https://github.com/eclipse-edc/Connector/tree/main/docs - about: Browse the documentation for more information diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md deleted file mode 100644 index 24f2fb4..0000000 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ /dev/null @@ -1,25 +0,0 @@ ---- -name: Feature Request -about: Help us with new ideas -title: '' -labels: [ "feature_request", "triage" ] -assignees: '' - ---- - -# Feature Request - -_If you are missing a feature or have an idea how to improve this project that should first be discussed, please feel -free to open up a [discussion](https://github.com/eclipse-edc/Connector/discussions/categories/ideas)._ - -## Which Areas Would Be Affected? - -_e.g., DPF, CI, build, transfer, etc._ - -## Why Is the Feature Desired? - -_Are there any requirements?_ - -## Solution Proposal - -_If possible, provide a (brief!) solution proposal._ diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index 2b33d88..0000000 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,18 +0,0 @@ -## What this PR changes/adds - -_Briefly describe WHAT your pr changes, which features it adds/modifies._ - -## Why it does that - -_Briefly state why the change was necessary._ - -## Further notes - -_List other areas of code that have changed but are not necessarily linked to the main feature. This could be method -signature changes, package declarations, bugs that were encountered and were fixed inline, etc._ - -## Linked Issue(s) - -Closes # <-- _insert Issue number if one exists_ - -_Please be sure to take a look at the [contributing guidelines](https://github.com/eclipse-edc/Connector/blob/main/CONTRIBUTING.md#submit-a-pull-request) and our [etiquette for pull requests](https://github.com/eclipse-edc/Connector/blob/main/pr_etiquette.md)._ diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 34fbbf4..5cb70db 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -53,7 +53,7 @@ jobs: Trigger-Snapshot: runs-on: ubuntu-latest # forks cannot trigger Jenkins - if: github.repository == 'eclipse-edc/Runtime-Metamodel' && github.event_name == 'push' + if: github.repository == 'eclipse-edc/Runtime-Metamodel' && github.event_name == 'push' && github.ref_name == 'main' needs: [Checkstyle, Javadoc, Unit-Tests] steps: # Trigger EF Jenkins. This job waits for Jenkins to complete the publishing, which may take a long time, because every @@ -71,4 +71,4 @@ jobs: "REPO": "https://github.com/eclipse-edc/Runtime-Metamodel" } job_name: "Publish-Component" - job_timeout: "3600" # Default 30 sec. (optional) \ No newline at end of file + job_timeout: "3600" # Default 30 sec. (optional) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 76a8e11..c297673 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -5,7 +5,7 @@ format.version = "1.1" assertj = "3.24.2" jackson = "2.15.2" jetbrainsAnnotation = "24.0.1" -junit = "5.9.3" +junit = "5.10.0" mockito = "5.4.0" [libraries]