Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi core R9 will remove ISE on some methods for Bundle, BundleContext, ServiceObjects and ServiceRegistration #172

Open
tjwatson opened this issue Dec 9, 2022 · 5 comments
Open

OSGi core R9 will remove ISE on some methods for Bundle, BundleContext, ServiceObjects and ServiceRegistration #172

tjwatson opened this issue Dec 9, 2022 · 5 comments
Assignees
@tjwatson

Comments

@tjwatson
Copy link
Contributor

tjwatson commented Dec 9, 2022 •
edited
Loading

See:
osgi/osgi#454
osgi/osgi#462
And
osgi/osgi#486
osgi/osgi#522

The following methods are removing the ISE to improve usability.

  • Bundle.uninstall

  • BundleContext.createFilter

  • BundleContext.getBundle

  • BundleContext.getProperty

  • BundleContext.removeServiceListener

  • BundleContext.removeBundleListener

  • BundleContext.removeFrameworkListener

  • BundleContext.ungetService

  • ServiceObjects.ungetService

  • ServiceRegistration.unregister

I think we can safely remove these now, even in our R8 implementation.
@bjhargrave
Copy link
Member

bjhargrave commented Dec 9, 2022 •
edited
Loading

osgi/osgi#476 also needs to be covered.

BundleContext.createFilter
BundleContext.getProperty

(I submitted osgi/osgi#524.)

@tjwatson
Copy link
Contributor Author

tjwatson commented Dec 9, 2022

BundleContext.createFilter
BundleContext.getProperty

Thanks, I didn't remember us agreeing to remove ISE from these, but I do agree that it would be best if we did here also.
I'll update the list in the initial comment.

@tjwatson tjwatson changed the title OSGi core R9 will remove ISE on some methods for BundleContext, ServiceObjects and ServiceRegistration OSGi core R9 will remove ISE on some methods for Bundle, BundleContext, ServiceObjects and ServiceRegistration Dec 9, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This issue has been inactive for 180 days and is therefore labeled as stale.
If this issue became irrelevant in the meantime please close it as completed. If it is still relevant and you think it should be fixed some possibilities are listed below.
Please read https://github.com/eclipse-equinox/.github/blob/main/CONTRIBUTING.md#contributing-to-eclipse-equinox for ways to influence development.

@github-actions github-actions bot added the stale label Jun 8, 2023
@laeubi laeubi removed the stale label Jun 8, 2023
anjumfatima90 added a commit to anjumfatima90/open-liberty that referenced this issue Nov 29, 2023
@anjumfatima90
Ignore ISE while stopping the server
7d8946b 
The tests do a stop server before updating the config. This stops the WAB io.openliberty.microprofile.openapi.2.0.internal.servlet.
But sometimes it throws ISE: BundleContext is no longer valid,  intermittently when ungetting the service because the service is chenged and the service tracker tries to unget the service and notices that the bundle context was closed and invalid.

Updated Equinox would no longer throw exceptions on invalid context when ungetService is called.
For reference: eclipse-equinox/equinox#172
anjumfatima90 added a commit to anjumfatima90/open-liberty that referenced this issue Dec 1, 2023
@anjumfatima90
Ignore ISE while stopping the server
21c3ea6 
The tests do a stop server before updating the config. This stops the WAB io.openliberty.microprofile.openapi.2.0.internal.servlet.
But sometimes it throws ISE: BundleContext is no longer valid,  intermittently when ungetting the service because the service is chenged and the service tracker tries to unget the service and notices that the bundle context was closed and invalid.

Updated Equinox would no longer throw exceptions on invalid context when ungetService is called.
For reference: eclipse-equinox/equinox#172
@tjwatson tjwatson self-assigned this Dec 4, 2023
mrsaldana pushed a commit to mrsaldana/open-liberty that referenced this issue Jan 18, 2024
@anjumfatima90 @mrsaldana
Ignore ISE while stopping the server
ab20c7c 
The tests do a stop server before updating the config. This stops the WAB io.openliberty.microprofile.openapi.2.0.internal.servlet.
But sometimes it throws ISE: BundleContext is no longer valid,  intermittently when ungetting the service because the service is chenged and the service tracker tries to unget the service and notices that the bundle context was closed and invalid.

Updated Equinox would no longer throw exceptions on invalid context when ungetService is called.
For reference: eclipse-equinox/equinox#172
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

This issue has been inactive for 180 days and is therefore labeled as stale.
If this issue became irrelevant in the meantime please close it as completed. If it is still relevant and you think it should be fixed some possibilities are listed below.
Please read https://github.com/eclipse-equinox/.github/blob/main/CONTRIBUTING.md#contributing-to-eclipse-equinox for ways to influence development.

@github-actions github-actions bot added the stale label Jun 2, 2024
@laeubi
Copy link
Member

laeubi commented Jun 2, 2024

I think this is still an issue.

@tjwatson tjwatson removed the stale label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjwatson tjwatson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bjhargrave @tjwatson @laeubi