Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syna submodule to current master #77

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

xai
Copy link
Member

@xai xai commented Dec 20, 2022

This fixes a search-related issue, which is related to eclipse-glsp/glsp#723.

Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@planger
Copy link
Member

planger commented Dec 20, 2022

Not sure why, but netlify didn't add a comment to print the link to the preview: https://deploy-preview-77--glsp.netlify.app/
@xai Is this already ok to merge? Thanks!

@xai
Copy link
Member Author

xai commented Dec 20, 2022

Not sure why, but netlify didn't add a comment to print the link to the preview: https://deploy-preview-77--glsp.netlify.app/ @xai Is this already ok to merge? Thanks!

Weird ... yes, it's good to merge. Then the search should work again.

@planger
Copy link
Member

planger commented Dec 20, 2022

Maybe we are still missing some permissions for netlify so it can publish a comment that links to the preview. I'll ask at the EclipseFoundation.

@planger planger merged commit f9e75a2 into eclipse-glsp:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants