GLSP-server 2.0.0 tests failures while building

[Yunabell-VU]

Hi,

I tried to build the glsp server (2.0.0) with the command:

mvn clean verify -Pm2 -Pfatjar

It all went well except for the TESTS part. Here's the log:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest
[ERROR] Tests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 3.467 s <<< FAILURE! - in org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest
[ERROR] org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest.deletingWatchedFileNotifiesClient  Time elapsed: 0.62 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest.assertNotifications(FileWatcherTest.java:153)
	at org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest.deletingWatchedFileNotifiesClient(FileWatcherTest.java:105)

[ERROR] org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest.changingWatchedFileNotifiesClient  Time elapsed: 0.619 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest.assertNotifications(FileWatcherTest.java:153)
	at org.eclipse.glsp.server.features.sourcemodelwatcher.FileWatcherTest.changingWatchedFileNotifiesClient(FileWatcherTest.java:88)

[INFO] Running org.eclipse.glsp.server.internal.util.GenericsUtilTest
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.054 s - in org.eclipse.glsp.server.internal.util.GenericsUtilTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   FileWatcherTest.changingWatchedFileNotifiesClient:88->assertNotifications:153 expected: <1> but was: <0>
[ERROR]   FileWatcherTest.deletingWatchedFileNotifiesClient:105->assertNotifications:153 expected: <1> but was: <0>
[INFO] 
[ERROR] Tests run: 36, Failures: 2, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for GLSP Parent 2.0.0:
[INFO] 
[INFO] GLSP Parent ........................................ SUCCESS [  0.654 s]
[INFO] org.eclipse.glsp.graph ............................. SUCCESS [  1.638 s]
[INFO] org.eclipse.glsp.server ............................ SUCCESS [  1.956 s]
[INFO] org.eclipse.glsp.layout ............................ SUCCESS [  0.211 s]
[INFO] org.eclipse.glsp.server.emf ........................ SUCCESS [  0.326 s]
[INFO] org.eclipse.glsp.server.websocket .................. SUCCESS [  0.219 s]
[INFO] org.eclipse.glsp.example.workflow .................. SUCCESS [  1.983 s]
[INFO] org.eclipse.glsp.server.test ....................... FAILURE [  3.989 s]
[INFO] org.eclipse.glsp.graph.test ........................ SKIPPED
[INFO] GLSP Server Tests .................................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  11.025 s
[INFO] Finished at: 2023-11-22T00:17:59+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project org.eclipse.glsp.server.test: There are test failures.
[ERROR] 
[ERROR] Please refer to /Users/yunabell/Downloads/glsp-server-2.0.0/tests/org.eclipse.glsp.server.test/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :org.eclipse.glsp.server.test

And when I tried to import the server project into Eclipse (via import Existing Maven project) and changed the Plug-in Development / Target Platform to 2023-09, there were still dependency issues. It seems all java files that containing Logger cannot be resolved.

Can you give any advice on how to solve the building issues?
Thank you!

[tortmayr]

Hi @Yunabell-VU

Unfortunately I cannot reproduce this issue. Building the 2.0.0 server with mvn clean verify -Pm2 -Pfatjar works for me as expected.
All tests succeed. I tested it with Linux(Ubuntu) and Windows. What OS are you using?

[Yunabell-VU]

Hi @tortmayr ,

Thanks for the reply. Here's my environment:

OS: macOS Ventura M2 chip
Java: 17
Maven: 3.9.5

[tortmayr]

Thanks for sharing.
I will reach out to a colleague that uses mac to see if they problem is reproducible.
If this is blocker for you, there is always the possibility to build with skipping tests (-Dmaven.test.skip=true)