Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple DefaultActionDispatcher are created and not properly disposed #1387

Closed
martin-fleck-at opened this issue Aug 12, 2024 · 1 comment · Fixed by eclipse-glsp/glsp-server#246
Assignees
Labels
bug Something isn't working server-java

Comments

@martin-fleck-at
Copy link
Contributor

Steps to reproduce:

  • Start the Java server and the standalone example
  • There is a temporary client session for each diagramType created to retrieve the diagram type specific
  • Check that there are two action dispatcher threads created
  • Reload the page
  • See that one action dispatcher thread remains and two new are created
  • Continue to see the number of remaining action dispatcher threads rising

image

It seems to me that the problem is that the action dispatcher also serves as an action handler for the internal JoinAction. The multi-binding does not ensure that we re-use the existing action dispatcher which would be achievable through a provider binding or other methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server-java
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants