From f2e34e7c52e4cc51fc93ecd1a498f12292061fdd Mon Sep 17 00:00:00 2001 From: Mattia Dal Ben Date: Thu, 19 Dec 2024 14:38:28 +0100 Subject: [PATCH 1/2] test: re-enable and fix DeploymentAgentTest (#5629) --- .../rest/packages/provider/test/PackagesRestServiceTest.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kura/test/org.eclipse.kura.rest.packages.provider.test/src/main/java/org/eclipse/kura/rest/packages/provider/test/PackagesRestServiceTest.java b/kura/test/org.eclipse.kura.rest.packages.provider.test/src/main/java/org/eclipse/kura/rest/packages/provider/test/PackagesRestServiceTest.java index bd026060ac..1181849dc0 100644 --- a/kura/test/org.eclipse.kura.rest.packages.provider.test/src/main/java/org/eclipse/kura/rest/packages/provider/test/PackagesRestServiceTest.java +++ b/kura/test/org.eclipse.kura.rest.packages.provider.test/src/main/java/org/eclipse/kura/rest/packages/provider/test/PackagesRestServiceTest.java @@ -59,7 +59,6 @@ import org.junit.Before; import org.junit.BeforeClass; import org.junit.Test; -import org.junit.Ignore; import org.junit.runner.RunWith; import org.junit.runners.Parameterized; import org.mockito.Mockito; @@ -70,7 +69,6 @@ import org.osgi.service.deploymentadmin.DeploymentAdmin; import org.osgi.service.deploymentadmin.DeploymentPackage; -@Ignore @RunWith(Parameterized.class) public class PackagesRestServiceTest extends AbstractRequestHandlerTest { @@ -290,7 +288,7 @@ public static void setUp() throws Exception { throw new IllegalStateException("Unable to get instance of: " + DeploymentRestService.class.getName()); } service.setDeploymentAdmin(deploymentAdmin); - + service.setDeploymentAgentService(deploymentAgentService); } /* From 9ccb148e3940938a8f8aaece0676753f3c664805 Mon Sep 17 00:00:00 2001 From: Mattia Dal Ben Date: Thu, 19 Dec 2024 17:10:40 +0100 Subject: [PATCH 2/2] ci: add `permissions` settings following good practices (#5625) --- .github/workflows/semantic-pr.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/semantic-pr.yml b/.github/workflows/semantic-pr.yml index 7596c12f88..3d812ad827 100644 --- a/.github/workflows/semantic-pr.yml +++ b/.github/workflows/semantic-pr.yml @@ -7,6 +7,9 @@ on: - edited - synchronize +permissions: + pull-requests: read + jobs: main: name: Validate PR title