New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins line endings check needs to skip metadata.blob files #19923

Closed

JasonFengJ9 opened this issue Jul 26, 2024 · 1 comment

Labels

Member

JasonFengJ9 commented Jul 26, 2024

https://openj9-jenkins.osuosl.org/job/PullRequest-LineEndingsCheck-OpenJ9/14543/console

15:17:42  test/functional/cmdLineTests/jfr/metadata.blob:164: trailing whitespace.
15:17:42  +��S����������

As per #19917 (comment), there is no way to generate this file dynamically currently. We need to skip the line endings check for this type of file.

The text was updated successfully, but these errors were encountered:

JasonFengJ9 added the comp:infra label

JasonFengJ9 mentioned this issue

Add triggerExecutionSample native #19917

Merged

Contributor

keithc-ca commented Jul 29, 2024

With the change to .gitattributes in #19917, the file metadata.blob will be classified as "data" and not subject to the line-end check.

JasonFengJ9 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment