Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdLineTester_jfr FileNotFoundException jfr.xml #19950

Closed
pshipton opened this issue Jul 31, 2024 · 8 comments · Fixed by #19957
Closed

cmdLineTester_jfr FileNotFoundException jfr.xml #19950

pshipton opened this issue Jul 31, 2024 · 8 comments · Fixed by #19957

Comments

@pshipton
Copy link
Member

pshipton commented Jul 31, 2024

https://openj9-jenkins.osuosl.org/job/Test_openjdk22_j9_sanity.functional_x86-64_linux_Nightly_testList_1/83/ - cent7-x64-6
cmdLineTester_jfr_0

05:43:51  TESTING:
05:43:51  java.io.FileNotFoundException: /home/jenkins/workspace/Test_openjdk22_j9_sanity.functional_x86-64_linux_Nightly_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/jfr/jfr.xml (No such file or directory)
05:43:51  	at java.base/java.io.FileInputStream.open0(Native Method)
05:43:51  	at java.base/java.io.FileInputStream.open(FileInputStream.java:213)
05:43:51  	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:152)
05:43:51  	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:106)
05:43:51  	at com.oti.j9.exclude.XMLParser.parse(XMLParser.java:455)
05:43:51  	at TestConfigParser.runTests(TestConfigParser.java:78)
05:43:51  	at MainTester.main(MainTester.java:106)
05:43:51  java.lang.NullPointerException
05:43:51  	at java.base/java.io.Reader.<init>(Reader.java:168)
05:43:51  	at java.base/java.io.InputStreamReader.<init>(InputStreamReader.java:88)
05:43:51  	at com.oti.j9.exclude.XMLParser.parse(XMLParser.java:468)
05:43:51  	at com.oti.j9.exclude.XMLParser.parse(XMLParser.java:459)
05:43:51  	at TestConfigParser.runTests(TestConfigParser.java:78)
05:43:51  	at MainTester.main(MainTester.java:106)
05:43:51  Exception in thread "main" java.lang.NullPointerException: Cannot invoke "TestSuite.printResults()" because "suite" is null
05:43:51  	at MainTester.main(MainTester.java:107)
@keithc-ca
Copy link
Contributor

Perhaps build.xml needs more general name patterns; that is

		<copy todir="${DEST}">
			<fileset dir="${src}/../">
				<filename name="metadata.blob" />
				<filename name="*.mk" />
				<filename name="*.xml" />
			</fileset>
		</copy>

should be?

		<copy todir="${DEST}">
			<fileset dir="${src}/../">
				<filename name="**/metadata.blob" />
				<filename name="**/*.mk" />
				<filename name="**/*.xml" />
			</fileset>
		</copy>

@tajila
Copy link
Contributor

tajila commented Aug 1, 2024

@thallium Can you try the sugestion above

@thallium
Copy link
Contributor

thallium commented Aug 1, 2024

Can you try the sugestion above

No that didn't work, maybe we need to revert back to <fileset dir="${src}/../" includes="*.xml,*.mk,metadata.blob" />.

@keithc-ca
Copy link
Contributor

The documentation at https://ant.apache.org/manual/Types/fileset.html suggests that my suggestion should be equivalent to

		<copy todir="${DEST}">
			<fileset dir="${src}/../">
				<include name="**/metadata.blob" />
				<include name="**/*.mk" />
				<include name="**/*.xml" />
			</fileset>
		</copy>

which does work.

@thallium
Copy link
Contributor

thallium commented Aug 1, 2024

Can confirm that using include tag works.

@keithc-ca
Copy link
Contributor

I also note that there are no files matching the *.mk pattern so that could be removed.

@thallium
Copy link
Contributor

thallium commented Aug 1, 2024

Opened PR: #19957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants