Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Offheap guard macro #20688

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

midronij
Copy link
Contributor

Replace all remaining instances of J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATION with J9VM_GC_SPARSE_HEAP_ALLOCATION

@midronij
Copy link
Contributor Author

@rmnattas @zl-wang here is the PR to update the remaining instances of the old offheap guard macro (which is what was causing the setMemory failure, as well as (potentially) some other failures/issues).

@zl-wang
Copy link
Contributor

zl-wang commented Nov 27, 2024

Jenkins test sanity.functional xlinux,aix,plinux,zlinux jdk8,jdk23

Replace all remaining instances of
J9VM_GC_ENABLE_SPARSE_HEAP_ALLOCATION with
J9VM_GC_SPARSE_HEAP_ALLOCATION

Signed-off-by: midronij <[email protected]>
@midronij
Copy link
Contributor Author

@zl-wang I believe the previous CI failures were due to this branch being a couple of commits behind. I rebased and confirmed that the build passes locally. Could you please rerun the CI tests when you have a chance?

@zl-wang
Copy link
Contributor

zl-wang commented Nov 27, 2024

Jenkins test sanity.functional xlinux,aix,plinux,zlinux jdk8,jdk23

@zl-wang
Copy link
Contributor

zl-wang commented Nov 28, 2024

xlinux failure is unrelated. aborted aix test was due to infra issue. merging ...

@zl-wang zl-wang merged commit d1adf51 into eclipse-openj9:master Nov 28, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants