Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK24 java/lang/Thread/virtual tests IllegalArgumentException: OpenJ9 doesn't support the API #20706

Open
JasonFengJ9 opened this issue Nov 28, 2024 · 9 comments
Open

JDK24 java/lang/Thread/virtual tests IllegalArgumentException: OpenJ9 doesn't support the API #20706

JasonFengJ9 opened this issue Nov 28, 2024 · 9 comments
Assignees
@fengxue-IS
Labels
comp:vm jdk24 test failure
Milestone
Java 24 (0.50)

Comments

@JasonFengJ9
Copy link
Member

JasonFengJ9 commented Nov 28, 2024 •
edited
Loading

Failure link

From an internal build(ubu22-aarch64-2):

00:07:31  openjdk version "24-internal" 2025-03-18
00:07:31  OpenJDK Runtime Environment (build 24-internal-adhoc.jenkins.BuildJDKnextaarch64linuxPersonal)
00:07:31  Eclipse OpenJ9 VM (build master-4ee9b77dbbd, JRE 24 Linux aarch64-64-Bit Compressed References 20241128_142 (JIT enabled, AOT enabled)
00:07:31  OpenJ9   - 4ee9b77dbbd
00:07:31  OMR      - 494474f6819
00:07:31  JCL      - 91383efdb6c based on jdk-24+25)

Rerun in Grinder - Change TARGET to run only the failed test targets.

Optional info

Failure output (captured from console output)

00:09:01  ===============================================
00:09:01  Running test jdk_lang_1 ...
00:09:01  ===============================================
00:09:01  jdk_lang_1 Start Time: Thu Nov 28 05:09:00 2024 Epoch Time (ms): 1732770540869
00:09:01  variation: -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache -XX:-JITServerTechPreviewMessage Mode650
00:09:01  JVM_OPTIONS:  -Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache -XX:-JITServerTechPreviewMessage -XX:-UseCompressedOops -Xverbosegclog 

01:19:58  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#default

01:19:58  STARTED    MonitorEnterExit::testReleaseWhenBlocked 'testReleaseWhenBlocked()'
01:19:58  org.junit.jupiter.engine.execution.ConditionEvaluationException: Failed to evaluate condition [org.junit.jupiter.api.condition.DisabledIfCondition]: OpenJ9 doesn't support the API i.e. the VM option might exist, but OpenJ9 can't retrieve it
01:19:58  	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
01:19:58  	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:197)
01:19:58  	at java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.tryAdvance(StreamSpliterators.java:305)
01:19:58  	at java.base/java.util.stream.Streams$ConcatSpliterator.tryAdvance(Streams.java:728)
01:19:58  	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:147)
01:19:58  	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:601)
01:19:58  	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:587)
01:19:58  	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:573)
01:19:58  	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
01:19:58  	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:270)
01:19:58  	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:687)
01:19:58  	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
01:19:58  	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
01:19:58  Caused by: java.lang.IllegalArgumentException: OpenJ9 doesn't support the API i.e. the VM option might exist, but OpenJ9 can't retrieve it
01:19:58  	at jdk.management/com.sun.management.internal.ExtendedHotSpotDiagnostic.getVMOption(ExtendedHotSpotDiagnostic.java:79)
01:19:58  	at LockingMode.isLegacy(LockingMode.java:35)
01:19:58  	at java.base/java.lang.reflect.Method.invoke(Method.java:571)
01:19:58  	at java.base/java.util.Optional.map(Optional.java:260)
01:19:58  	... 13 more
01:19:58  FAILED     MonitorEnterExit::testReleaseWhenBlocked 'testReleaseWhenBlocked()'

01:20:06  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#LM_LEGACY

01:20:09  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#LM_LIGHTWEIGHT

01:20:59  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#Xcomp-LM_LEGACY

01:21:05  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#Xcomp-LM_LIGHTWEIGHT

01:21:55  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#Xcomp-noTieredCompilation-LM_LEGACY

01:21:59  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#Xcomp-noTieredCompilation-LM_LIGHTWEIGHT

01:22:59  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#Xcomp-TieredStopAtLevel1-LM_LEGACY

01:23:02  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#Xcomp-TieredStopAtLevel1-LM_LIGHTWEIGHT

01:23:05  TEST: java/lang/Thread/virtual/MonitorEnterExit.java#Xint-LM_LEGACY

...



01:44:37  jdk_lang_1_FAILED

50x grinder - all failed
@JasonFengJ9 JasonFengJ9 added this to the Java 24 (0.50) milestone Nov 28, 2024
@github-actions GitHub Actions
Copy link

Issue Number: 20706
Status: Open
Recommended Components: comp:vm, comp:jit, comp:test

@pshipton
Copy link
Member

java/lang/Thread/virtual/MonitorWaitNotify.java#LM_LEGACY.MonitorWaitNotify_LM_LEGACY
java/lang/Thread/virtual/MonitorWaitNotify.java#LM_LIGHTWEIGHT.MonitorWaitNotify_LM_LIGHTWEIGHT
java/lang/Thread/virtual/MonitorWaitNotify.java#Xcomp-LM_LEGACY.MonitorWaitNotify_Xcomp-LM_LEGACY
java/lang/Thread/virtual/MonitorWaitNotify.java#Xcomp-LM_LIGHTWEIGHT.MonitorWaitNotify_Xcomp-LM_LIGHTWEIGHT
java/lang/Thread/virtual/MonitorWaitNotify.java#Xcomp-TieredStopAtLevel1-LM_LEGACY.MonitorWaitNotify_Xcomp-TieredStopAtLevel1-LM_LEGACY
java/lang/Thread/virtual/MonitorWaitNotify.java#Xcomp-TieredStopAtLevel1-LM_LIGHTWEIGHT.MonitorWaitNotify_Xcomp-TieredStopAtLevel1-LM_LIGHTWEIGHT
java/lang/Thread/virtual/MonitorWaitNotify.java#Xcomp-noTieredCompilation-LM_LEGACY.MonitorWaitNotify_Xcomp-noTieredCompilation-LM_LEGACY
java/lang/Thread/virtual/MonitorWaitNotify.java#Xcomp-noTieredCompilation-LM_LIGHTWEIGHT.MonitorWaitNotify_Xcomp-noTieredCompilation-LM_LIGHTWEIGHT
java/lang/Thread/virtual/MonitorWaitNotify.java#Xint-LM_LEGACY.MonitorWaitNotify_Xint-LM_LEGACY
java/lang/Thread/virtual/MonitorWaitNotify.java#Xint-LM_LIGHTWEIGHT.MonitorWaitNotify_Xint-LM_LIGHTWEIGHT
java/lang/Thread/virtual/MonitorWaitNotify.java#default.MonitorWaitNotify_default

@pshipton
Copy link
Member

java/lang/Thread/virtual/Parking.java#Xcomp-noTieredCompilation.Parking_Xcomp-noTieredCompilation
java/lang/Thread/virtual/Parking.java#Xcomp.Parking_Xcomp
java/lang/Thread/virtual/Parking.java#Xint.Parking_Xint
java/lang/Thread/virtual/Parking.java#default.Parking_default

@pshipton
Copy link
Member 

java/lang/Thread/virtual/ThreadAPI.java#default.ThreadAPI_default
java/lang/Thread/virtual/ThreadAPI.java#no-vmcontinuations.ThreadAPI_no-vmcontinuations

@pshipton
Copy link
Member

I will modify at LockingMode.isLegacy(LockingMode.java:35)

pshipton added a commit to pshipton/openj9-openjdk-jdk24 that referenced this issue Jan 20, 2025
@pshipton
Modify test LockingMode.isLegacy() to return false for OpenJ9
6626601 
Issue eclipse-openj9/openj9#20706

Signed-off-by: Peter Shipton <[email protected]>
@pshipton
Copy link
Member

I tried setting legacy locking to false, but all the testing timed out.
https://openj9-jenkins.osuosl.org/job/Grinder/4074/

I'll try a run with it set to true.

pshipton added a commit to pshipton/openj9-openjdk-jdk24 that referenced this issue Jan 21, 2025
@pshipton
Modify test LockingMode.isLegacy() to return true for OpenJ9
946110c 
Issue eclipse-openj9/openj9#20706
@pshipton
Copy link
Member

Grinder with legacy locking set to true.
https://openj9-jenkins.osuosl.org/job/Grinder/4075/

@tajila
Copy link
Contributor

tajila commented Jan 21, 2025

I think we should be using LockingMode.isLegacy() == true until JEP 491 is merged.

pshipton added a commit to pshipton/openj9-openjdk-jdk24 that referenced this issue Jan 21, 2025
@pshipton
Modify test LockingMode.isLegacy() to return true for OpenJ9
baad1a4 
Issue eclipse-openj9/openj9#20706
@pshipton pshipton mentioned this issue Jan 21, 2025
Merged
@pshipton
Copy link
Member

It's better now using true, opened ibmruntimes/openj9-openjdk-jdk24#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengxue-IS fengxue-IS

Labels
comp:vm jdk24 test failure
Projects
None yet
Milestone
Java 24 (0.50)
Development

No branches or pull requests
4 participants
@fengxue-IS @tajila @JasonFengJ9 @pshipton