Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose logging to dependency table #20712

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

cjjdespres
Copy link
Contributor

@cjjdespres cjjdespres commented Nov 29, 2024

The verbose options dependencyTracking and dependencyTrackingDetails turn on various verbose log messages related to class and method tracking in the dependency table, and method dependency gathering at compile time.

Depends on eclipse-omr/omr#7571

@cjjdespres
Copy link
Contributor Author

Attn @mpirvu. These are some of the verbose messages I've been using for development. This depends on some verbose flags being added to omr, so I'll open that PR, link it here, and set this to ready if everything looks good and that's merged.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

runtime/compiler/codegen/J9AheadOfTimeCompile.cpp Outdated Show resolved Hide resolved
runtime/compiler/codegen/J9AheadOfTimeCompile.cpp Outdated Show resolved Hide resolved
runtime/compiler/compile/J9Compilation.cpp Outdated Show resolved Hide resolved
runtime/compiler/env/DependencyTable.cpp Show resolved Hide resolved
runtime/compiler/env/DependencyTable.cpp Outdated Show resolved Hide resolved
@cjjdespres cjjdespres marked this pull request as ready for review December 2, 2024 16:44
@cjjdespres cjjdespres requested a review from dsouzai as a code owner December 2, 2024 16:44
@cjjdespres
Copy link
Contributor Author

Marked the PR ready now that eclipse-omr/omr#7571 has been merged.

@pshipton
Copy link
Member

pshipton commented Dec 2, 2024

Keep in mind the OMR PR also needs to promote, which won't happen before ~ tomorrow afternoon, assuming all goes well.

@mpirvu
Copy link
Contributor

mpirvu commented Dec 3, 2024

jenkins compile all jdk21

@mpirvu
Copy link
Contributor

mpirvu commented Dec 3, 2024

Compilation error on mac

 /Users/jenkins/workspace/Build_JDK21_aarch64_mac_Personal/openj9/runtime/compiler/codegen/J9AheadOfTimeCompile.cpp:2637:16: error: use of undeclared identifier 'TR_VerboseLog'; did you mean 'TR_VerboseFlags'?
12:14:41                 TR_VerboseLog::writeLineLocked(TR_Vlog_INFO, "Method %p compiled with 0 tracked dependencies", method);
12:14:41                 ^~~~~~~~~~~~~
12:14:41                 TR_VerboseFlags

The verbose options dependencyTracking and dependencyTrackingDetails
turn on various verbose log messages related to class and method
tracking in the dependency table, and method dependency gathering at
compile time.

Signed-off-by: Christian Despres <[email protected]>
@cjjdespres
Copy link
Contributor Author

I've included env/VerboseLog.hpp manually in that file now.

@mpirvu
Copy link
Contributor

mpirvu commented Dec 3, 2024

jenkins compile amac jdk21

@mpirvu mpirvu merged commit 38a8276 into eclipse-openj9:master Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants