Fix some include warnings in JITServer #20719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attn @mpirvu. Just a small change to avoid some warnings I've been getting. I also removed an unused |
mpirvu
reviewed
Nov 29, 2024
| @@ -26,7 +26,7 @@ | |||
| #include <unistd.h> | |||
| #include "net/LoadSSLLibs.hpp" | |||
| #include "net/Message.hpp" | |||
| #include "infra/Statistics.hpp" | |||
There was a problem hiding this comment.
Statistics.hpp is still needed for
#if defined(MESSAGE_SIZE_STATS)
static TR_Stats _msgSizeStats[MessageType::MessageType_MAXTYPE];
#endif /* defined(MESSAGE_SIZE_STATS) */
These headers mention certain types but do not include the relevant headers for them. This does not yet cause a compilation error because all of their use sites are coincidentally only after those headers have been included. Signed-off-by: Christian Despres <[email protected]>
cjjdespres
force-pushed
the
jitserver-include-warnings
branch
from
09a1794 to
c21f5ee
Compare
mpirvu
approved these changes
Nov 30, 2024
|
jenkins compile all jdk8,jdk23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These headers mention certain types but do not include the relevant headers for them. This does not yet cause a compilation error because all of their use sites are coincidentally only after those headers have been included.