Remove System.security field and getSecurityManager calls for JDK 24 #20851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonFengJ9
reviewed
Dec 19, 2024
theresa-m
force-pushed
the
remove_systemsec
branch
from
5204cb3 to
ed204ac
Compare
JasonFengJ9
reviewed
Dec 20, 2024
theresa-m
force-pushed
the
remove_systemsec
branch
from
ed204ac to
8a971b8
Compare
keithc-ca
requested changes
Jan 3, 2025
keithc-ca
reviewed
Jan 3, 2025
With the removal of the security manager (JEP 486) the System.security field is not used for anything meaningful. Signed-off-by: Theresa Mammarella <[email protected]>
These calls are not needed since System.getSecurityManager returns null for JDK 24+. Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
remove_systemsec
branch
from
8a971b8 to
dc6586b
Compare
keithc-ca
requested changes
Jan 7, 2025
Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
remove_systemsec
branch
from
dc6586b to
93fd41b
Compare
|
Jenkins test sanity amac jdk17,jdk24 |
|
Compiling test code failed in each job in I'll retry on Linux. |
|
The sanity.openjdk test failures are not unexpected. |
|
Jenkins test sanity.functional alinux jdk24 |
|
Linux at least offers a stack trace that may help: |
|
The failure in the other job is #20835. |
|
The segmentation fault problems are tracked by #20870. |
keithc-ca
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
System.securityprivate field from Java 24 which fixes the previously failing reflection check toSystem.securityintest/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class.java.For previous JDK versions
System.securitywas included injdk/internal/reflect/Reflection.fieldFilterMapwhich would cause aNoSuchFieldExceptionto be thrown during an attempt to reflectively accessSystem.security. In JDK 24 OpenJDK has removed thesecurityfield from the System class and from the fieldFilterMap as well. Since OpenJ9 does not need this field in JDK 24 I will remove it as well. The absence of this field will cause aNoSuchFieldExceptionto be thrown if reflective access is attempted.I have also removed all the calls to
System.getSecurityManagerfrom JDK 24+ in the System class since it just returns null. There are many other unnecessary calls toSystem.getSecurityManagerthroughout the code base. I will work on removing these for JDK 24 in a future pull request.Related: #20563