JIT compile AccessController.doPrivileged in JDK 24+ #20859
Conversation
|
@dsouzai can you take a look at this change or advise on the best person to review? |
|
@hzongaro could you review this change? |
|
By the way, may I suggest you remove the words "As I understand it" from the start of the commit comment? |
theresa-m
force-pushed
the
jit_scc
branch
5 times, most recently
from
a6818c1 to
3b6b96d
Compare
theresa-m
changed the title
|
Please update the commit message and the title here to spell JIT properly and consistently. |
theresa-m
changed the title
AccessController.doPrivileged methods have historically not been compiled by the JIT due to security manager use. Starting in JDK 24 the security manager will be removed and these methods can be compiled. Signed-off-by: Theresa Mammarella <[email protected]>
|
I ran this change through a personal build and it is causing a crash during test compilation https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk24_j9_sanity.functional_x86-64_linux_Personal_testList_0/9/consoleFull. |
|
That crash looks like #20870. About your only recourse is to try again. |
|
Interesting... I've tried twice in a personal build and once locally and I got the same crash all three times. Perhaps I can try again when the issue is resolved. edit: I tried it again locally and it was okay I'll give it another shot with a personal build |
|
My latest builds contains only known failures that are not related to this change https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk24_j9_sanity.functional_x86-64_linux_Personal/10/ |
|
Jenkins test sanity.functional,sanity.openjdk xlinux,alinux,plinux jdk8,jdk21,jdk24 |
|
JDK 24 test failures for alinux and plinux were all known problems. I will rerun the JDK 24 xlinux testing which failed to run to completion. Jenkins test sanity.functional,sanity.openjdk xlinux jdk24 |
|
Trying xlinux JDK 24 testing once more. . . . Jenkins test sanity.functional,sanity.openjdk xlinux jdk24 |
|
In JDK 24 xlinux sanity.functional testing:
The JDK 24 xlinux sanity.openjdk failures all appear to be due to known problems. Merging. |
AccessController.doPrivileged methods have historically
not been compiled by the JIT due to security manager use.
Starting in JDK 24 the security manager will be removed
and these methods can be compiled.
Related: #20563