Account for Truncated Signatures in a JITServerHelpers Assertion #20883
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional checks so that the assertion "(memcmp(dst, str, J9UTF8_TOTAL_SIZE(str)) == 0)" in packCallBack() also accounts for the dst signature being truncated for generated classes. Prevents the non-fatal assertion from failing. Fixes eclipse-openj9#20046 Signed-off-by: Luke Li <[email protected]>
|
@mpirvu can you have a look at this? |
mpirvu
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Looks ok to me.
What guarantees do we have that the memcmp will not access memory beyond the UTF-8 boundaries? The name _generatedPrefixLength suggests that we only compare a few characters in the beginning, but is there a guarantee that the length of src and dst is at least as large as _generatedPrefixLength?
@cjjdespres As the original author, could also please review?
|
The lengths should match because |
|
jenkins compile xlinuxjit jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional checks so that the assertion "(memcmp(dst, str, J9UTF8_TOTAL_SIZE(str)) == 0)" in packCallBack() also accounts for the dst signature being truncated for generated classes. Prevents the non-fatal assertion from failing.
Fixes #20046