Support for storing all IProfile info to SCC at shutdown #20886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IProfiler does not profile direct calls. However, the optimizer may create artificial profiler entries when it calls setCallCount(). These artificial entries are marked to be non-persistent and we only set the frequency (totalCount) ignoring the class of the method that is called. This commit also records the class of the method to be called. Doing so does not require additional storage. Signed-off-by: Marius Pirvu <[email protected]>
This change will allow createBalancedBST to be called from places where the Compilation object is not readily available. Signed-off-by: Marius Pirvu <[email protected]>
The goal is to use the code from TR_AggregationHT in more places (for instance for dumping all IProfiler info into the SCC). Signed-off-by: Marius Pirvu <[email protected]>
Signed-off-by: Marius Pirvu <[email protected]>
mpirvu
changed the title
dsouzai
reviewed
Jan 6, 2025
|
I have eliminated the comments that were not needed. |
dsouzai
approved these changes
Jan 7, 2025
|
jenkins test sanity.functional jdk8,jdk21 all |
|
jenkins test sanity.functional all jdk8,jdk21 |
|
There are compilation errors on non-linux platforms: |
This commit implements the TR_IProfiler::persistAllEntries() method which can write all IProfiler entries into the SCC on a ROMMethod by ROMMethod basis. Signed-off-by: Marius Pirvu <[email protected]>
|
jenkins compile aix jdk21 |
|
jenkins test sanity.functional jdk8,jdk21 all |
|
jenkins test sanity.functional all jdk8,jdk21 |
|
Build on AIX failed due to infra but it did pass on a previous build attempt: #20886 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements: