Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include temporarily disabled Valhalla code #20897

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

h3110n3rv3
Copy link
Contributor

@h3110n3rv3 h3110n3rv3 commented Jan 9, 2025

The changes reflect part of the fix for issue #19144.

Removed !INLINE-TYPES for changes now supported by Valhalla project.
There is still some code not supported by Valhalla.

Signed-off-by: Nick Kamal <[email protected]>

@h3110n3rv3 h3110n3rv3 force-pushed the valhala-placegolder-code branch from d2876ea to 8f2f2f2 Compare January 9, 2025 18:17
@h3110n3rv3
Copy link
Contributor Author

valhalla build
@TobiAjila @theresa-m could you please review?

@theresa-m theresa-m added comp:vm project:valhalla Used to track Project Valhalla related work labels Jan 10, 2025
Copy link
Contributor

@theresa-m theresa-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @h3110n3rv3 and finding so many of these. Looks good to me.

@tajila
Copy link
Contributor

tajila commented Jan 10, 2025

jenkins test sanity alinux64 jdk23

@tajila tajila merged commit c8dd890 into eclipse-openj9:master Jan 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants