Allowing JFR to get J9Class of hidden and anonymous classes #20979
+64
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tajila can you please review? |
tajila
reviewed
Jan 21, 2025
runtime/vm/KeyHashTable.c
Outdated
| @@ -333,7 +342,7 @@ hashClassTableNew(J9JavaVM *javaVM, U_32 initialSize) | |||
| } | |||
|
|
|||
| J9Class * | |||
| hashClassTableAt(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength) | |||
| hashClassTableAt(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength, BOOLEAN ignoreHiddenClass) | |||
There was a problem hiding this comment.
I should have mentioned this earlier, but you can make:
hashClassTableAtImpl(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength, BOOLEAN ignoreHiddenClass) { }
and then
hashClassTableAt(J9ClassLoader *classLoader, U_8 *className, UDATA classNameLength)
{
return hashClassTableAtImpl(classLoader, className, classNameLength, TRUE);
}
So you dont need to update all the places its used.
There was a problem hiding this comment.
Updated my PR. I added hashClassTableAtImpl to vm_api.h, is that what I'm supposed to do?
theresa-m
reviewed
Jan 21, 2025
Signed-off-by: Gengchen Tuo <[email protected]>
theresa-m
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.