From e24c6e261a3ea4d41af30027fde773789240045d Mon Sep 17 00:00:00 2001 From: Andrey Loskutov Date: Fri, 12 Jan 2024 06:58:02 +0100 Subject: [PATCH] Update exception signature change in LogEntry tests See https://github.com/eclipse-platform/eclipse.platform.ui/pull/1493 --- .../pde/ui/tests/views/log/LogEntryTest.java | 30 +++++++++++-------- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/views/log/LogEntryTest.java b/ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/views/log/LogEntryTest.java index 3ffd183ceb..08376b6b6a 100644 --- a/ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/views/log/LogEntryTest.java +++ b/ui/org.eclipse.pde.ui.tests/src/org/eclipse/pde/ui/tests/views/log/LogEntryTest.java @@ -17,7 +17,6 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.fail; -import java.text.ParseException; import java.util.Calendar; import java.util.GregorianCalendar; @@ -26,7 +25,7 @@ public class LogEntryTest { @Test - public void testProcessEntry() throws ParseException { + public void testProcessEntry() throws Exception { LogEntry entry = new LogEntry(); entry.processEntry("!ENTRY org.eclipse.pde.ui 1 100 2009-01-03 11:15:30.123"); @@ -40,7 +39,7 @@ public void testProcessEntry() throws ParseException { } @Test - public void testProcessFrameworkEntry() throws ParseException { + public void testProcessFrameworkEntry() throws Exception { LogEntry entry = new LogEntry(); entry.processEntry("!ENTRY org.eclipse.osgi 2009-01-07 11:15:30.123"); @@ -54,7 +53,7 @@ public void testProcessFrameworkEntry() throws ParseException { } @Test - public void testProcessSubEntry() throws ParseException { + public void testProcessSubEntry() throws Exception { LogEntry entry = new LogEntry(); int depth = entry.processSubEntry("!SUBENTRY 1 org.eclipse.osgi 1 101 2009-01-08 11:15:30.123"); @@ -70,7 +69,7 @@ public void testProcessSubEntry() throws ParseException { } @Test - public void testProcessFrameworkSubEntry() throws ParseException { + public void testProcessFrameworkSubEntry() throws Exception { LogEntry entry = new LogEntry(); int depth = entry.processSubEntry("!SUBENTRY 1 org.eclipse.osgi 2009-01-01 11:15:30.123"); @@ -86,30 +85,37 @@ public void testProcessFrameworkSubEntry() throws ParseException { } @Test - public void testInvalidEntry() { + public void testInvalidEntry() throws Exception { // see https://bugs.eclipse.org/bugs/show_bug.cgi?id=271733 try { LogEntry entry = new LogEntry(); entry.processEntry("!ENTRY org.eclipse.core.contenttype 4 0"); - fail("Should throw ParseException for invalid entry"); - } catch (ParseException e) { + fail("Should throw IllegalArgumentException for invalid entry"); + } catch (IllegalArgumentException e) { // good } try { LogEntry entry = new LogEntry(); entry.processEntry("!ENTRY org.eclipse.ui 4 0"); - fail("Should throw ParseException for invalid entry"); - } catch (ParseException e) { + fail("Should throw IllegalArgumentException for invalid entry"); + } catch (IllegalArgumentException e) { // good } try { LogEntry entry = new LogEntry(); entry.processEntry("!ENTRY org.eclipse.ui 4 0"); - fail("Should throw ParseException for invalid entry"); - } catch (ParseException e) { + fail("Should throw IllegalArgumentException for invalid entry"); + } catch (IllegalArgumentException e) { + // good + } + try { + LogEntry entry = new LogEntry(); + entry.processEntry("!SUBENTRY 1 Failed to read file 4 0 2024-01-11 13:20:30.288"); + fail("Should throw IllegalArgumentException for invalid entry"); + } catch (IllegalArgumentException e) { // good } }