Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat 'Require-Capability: osgi.ee' as equivalent to 'Bundle-RequiredExecutionEnvironment' #140

Open
HannesWell opened this issue Jun 5, 2022 · 0 comments · May be fixed by #1000
Open

Treat 'Require-Capability: osgi.ee' as equivalent to 'Bundle-RequiredExecutionEnvironment' #140

HannesWell opened this issue Jun 5, 2022 · 0 comments · May be fixed by #1000

Comments

@HannesWell
Copy link
Member

HannesWell commented Jun 5, 2022 •
edited
Loading

If a bundle declares a osgi.ee capability like Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.7))" but no Bundle-RequiredExecutionEnvironment the Manifest-Editor creates a warning about a missing execution environment and shows an empty List of EEs.

But BREE is deprecated by the OSGi spec:

The Bundle-RequiredExecutionEnvironment manifest header provides the same function as the osgi.ee Namespace. It allows a bundle to depend on the execution environment. This header is deprecated but must be fully supported by a compliant framework. Bundles should not mix these headers but use either an osgi.ee requirement or this header.

http://docs.osgi.org/specification/osgi.core/8.0.0/framework.module.html#framework.module.bree

Therefore such an osgi.ee capability should be treated equivalently regarding warnings, internal processing (I have not yet checked if it is already considered, maybe implicitly by the resolver?) and visual representation regarding in the Editor.

We could even consider to create osgi.ee capabilities instead of BREEs if new ones are added via the editor.

This is similar to Bug 324209.
This was referenced Jun 5, 2022
Closed
Closed
@HannesWell HannesWell mentioned this issue Feb 15, 2023
Closed
alshamams added a commit to alshamams/eclipse.pde that referenced this issue Dec 11, 2023
@alshamams
Consider Require-Capability when validating BREE
0e64a00 
Presence of osgi.ee capability ‘Require-Capability’ should mitigate
absence of BREE headers in the manifest. The current parser has no
awareness of Require-Capability header. In future the parser should
consider this header too while evaluating BREE header.
Fixes: eclipse-pde#140
@alshamams alshamams linked a pull request Dec 11, 2023 that will close this issue
Open
laeubi pushed a commit to alshamams/eclipse.pde that referenced this issue Jan 27, 2024
@alshamams @laeubi
Consider Require-Capability when validating BREE
a5734c6 
Presence of osgi.ee capability ‘Require-Capability’ should mitigate
absence of BREE headers in the manifest. The current parser has no
awareness of Require-Capability header. In future the parser should
consider this header too while evaluating BREE header.
Fixes: eclipse-pde#140
laeubi pushed a commit to alshamams/eclipse.pde that referenced this issue Feb 11, 2024
@alshamams @laeubi
Consider Require-Capability when validating BREE
60dbc23 
Presence of osgi.ee capability ‘Require-Capability’ should mitigate
absence of BREE headers in the manifest. The current parser has no
awareness of Require-Capability header. In future the parser should
consider this header too while evaluating BREE header.
Fixes: eclipse-pde#140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider Require-Capability when validating BREE alshamams/eclipse.pde
1 participant
@HannesWell