Update target job to use released version of Tycho and remove draft flag #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verification Jobs wont cover this. |
HannesWell
reviewed
Oct 2, 2024
| mvn -f eclipse.platform.releng.prereqs.sdk | ||
| org.eclipse.tycho.extras:tycho-version-bump-plugin:4.0.9-SNAPSHOT:update-target | ||
| mvn -ntp -f eclipse.platform.releng.prereqs.sdk | ||
| org.eclipse.tycho.extras:tycho-version-bump-plugin:4.0.9:update-target |
There was a problem hiding this comment.
Wouldn't it be better to add tycho-version-bump-plugin to the pluginManagement section in the eclipse-parent pom and use the tycho.version used for all other Tycho plugins?
This would avoid future maintenance of that version.
There was a problem hiding this comment.
As this is a standalone action I would rather not blindly update it if there are no relevant changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.