-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve workspace lock dialog. #2343
Comments
When you working on this anyway .. add the PID (ProcessID )that holds the lock |
... and I've updated TODO's list. |
Note, some of the information (like hostname) might require API calls that might hang Eclipse, so we should avoid using them. Other data (like So both kind of data should be optional and shouldn't break new code if missing. Also new code should make sure it can work with lock files created by different platform versions, as it is possible to use same workspace with different Eclipse versions too. |
Write workspace lock info like user, host, java process id, display properties onto .lock file if the lock was successful. Read the current lock data in case of lock was unsuccessful and shown it in error dialog. If the .lock file has no info then nothing is shown. For older eclipse versions. see eclipse-platform#2343
Write workspace lock info like user, host, java process id, display properties onto .lock file if the lock was successful. Read the current lock data in case of lock was unsuccessful and shown it in error dialog. If the .lock file has no info then nothing is shown. For older eclipse versions. see eclipse-platform#2343
If the workspace directory which we are trying to use is locked then we get the below dialog.
This dialog is good. But we can improve this dialog with some other information like
user.name
: This greatly help the user in case of multi user environment where multiple developers uses common workspace which is located on the network.host-name
: This gives little more hint that from host that lock has been initiated.DISPLAY
on Linux - gives a hint which VNC session is locking workspaceThis will make user life easy if they know who has held the workspace and they can talk to the respective developer.
Plan:
We can write the above mentioned information onto
.metadata/.lock file
file. When any user successfully acquires the lock.If the next user failed to get the lock, Then we can read this file and show this data (if available on current OS) inside error dialog above shown.
The text was updated successfully, but these errors were encountered: