Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for widget diagnostics provider in View-based Forms #4390

Open
pcdavid opened this issue Jan 7, 2025 · 1 comment · Fixed by #4396 · May be fixed by #4409
Open

Add support for widget diagnostics provider in View-based Forms #4390

pcdavid opened this issue Jan 7, 2025 · 1 comment · Fixed by #4396 · May be fixed by #4409
Assignees
@pcdavid
Labels
difficulty: medium type: feature request
Milestone
2025.2.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Jan 7, 2025 •
edited
Loading

Programmatically-defined widgets have support for .diagnosticsProvider(), which are used for example in the default details view to expose EMF Diagnostics (see how EStringIfDescriptionProvider.getTextareaDescription(), PropertiesValidationProvider and DomainValidator work together to implement this).

However this capability is not exposed to View-based Forms. form.ecore does not provide any way to configure diagnostics for a widget, and given this lack of input ViewFormDescriptionConverterSwitch configures all the widgets it produces with no diagnostics provider (.diagnosticsProvider(variableManager -> List.of())).
@pcdavid pcdavid self-assigned this Jan 7, 2025
@pcdavid pcdavid added this to the 2025.2.0 milestone Jan 7, 2025
@pcdavid pcdavid linked a pull request Jan 9, 2025 that will close this issue
[doc] Add ADR for widget diagnostics provider in View-based Forms #4396
Merged
39 tasks
@pcdavid
Copy link
Member Author

pcdavid commented Jan 12, 2025 •
edited
Loading

Reopeing the issue; only the ADR has been merged for now.

@pcdavid pcdavid reopened this Jan 12, 2025
pcdavid added a commit that referenced this issue Jan 14, 2025
@pcdavid
[4390] Add support for diagnostics on View-based widgets
f0798bf 
Bug: #4390
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid linked a pull request Jan 14, 2025 that will close this issue
Open
39 tasks
@pcdavid pcdavid linked a pull request Jan 14, 2025 that will close this issue
[4390] Add support for diagnostics on View-based widgets #4409
Open
39 tasks
pcdavid added a commit that referenced this issue Jan 16, 2025
@pcdavid
[4390] Add support for diagnostics on View-based widgets
d12f1cf 
Bug: #4390
Signed-off-by: Pierre-Charles David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium type: feature request
Projects
None yet
Milestone
2025.2.0
1 participant
@pcdavid