Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenWithService change seems to be breaking changes #13837

Closed
bhufmann opened this issue Jun 21, 2024 · 3 comments · Fixed by #13893
Closed

OpenWithService change seems to be breaking changes #13837

bhufmann opened this issue Jun 21, 2024 · 3 comments · Fixed by #13893
Milestone

Comments

@bhufmann
Copy link

Bug Description:

When upgrading the theia-traceviewer (eclipse-cdt-cloud/theia-trace-extension#1085) to recent Theia community release 1.49.1, I noticed that the feature Open With -> Trace Viewer is not working anymore. It is used to open trace files or trace folders from the navigator's Open With menu when selecting either a file or folder. I figured out how to fix it (see PR).

I think this should be mentioned as a breaking change in the CHANGELOG.md#breaking_changes

Additional Information

  • Operating System: All
  • Theia Version: 1.49.1

Related change: #13573

@JonasHelming
Copy link
Contributor

@msujew

@tortmayr
Copy link
Contributor

tortmayr commented Jul 7, 2024

I agree, we also encountered issues with the changed behavior of open with when upgrading GLSP projects.
The changes of #13573 are technically not breaking any API, but they introduce a behavioral change which still should be mentioned in the changelog.
Before this change any widget/view etc. configured with a OpenHandler would indirectly also be available in the open with context menu. With the introduction of the OpenWithService this is no longer the case. If adopters want that their custom opener shows up as open with candidate they have to manually inject the OpenWithService and register a handler for it.

@msujew
Copy link
Member

msujew commented Jul 7, 2024

Sorry, right. I didn't really think about people relying on the implicit behavior that existed previously. I'll provide a patch for that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants