Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core package is missing dependencies in v0.8.15 #1317

Closed
hasanheroglu opened this issue Aug 20, 2024 · 5 comments · Fixed by #1318
Closed

core package is missing dependencies in v0.8.15 #1317

hasanheroglu opened this issue Aug 20, 2024 · 5 comments · Fixed by #1318
Labels
bug Something isn't working core Issues with the core library dependencies Pull requests that update a dependency file

Comments

@hasanheroglu
Copy link
Contributor

hasanheroglu commented Aug 20, 2024

serdes.ts uses two dependencies is-absolute-url and url-toolkit which are not included in core's package.json. Since td-tools package installs those two dependencies it may seem working in the monorepo but when it is installed alone it causes an error.

@JKRhb JKRhb added bug Something isn't working core Issues with the core library dependencies Pull requests that update a dependency file labels Aug 20, 2024
@danielpeintner
Copy link
Member

Mhh, the problem was surely introduced in #1312 and I will provide a fix soon.

I wonder whether there is a way to detect such an issue ... any ideas ?

@hasanheroglu
Copy link
Contributor Author

hasanheroglu commented Aug 21, 2024

I wonder whether there is a way to detect such an issue ... any ideas ?

We can separate CI runs for each package. We install only package-specific and root dependencies (devDependencies of the root package.json), run the test, and see if it passes. I can work on this if it makes sense for you.

@danielpeintner
Copy link
Member

I can work on this if it makes sense for you.

Thanks, that would be great, but I think it does not have high priority. I opened #1319 to track it.

@relu91
Copy link
Member

relu91 commented Aug 21, 2024

We can separate CI runs for each package. We install only package-specific and root dependencies (devDependencies of the root package.json), run the test, and see if it passes. I can work on this if it makes sense for you.

I'm curious to see a concrete PR on this, but I'm afraid it will get quite complicated to maintain and defeat the advantages of having a mono repo.

@danielpeintner
Copy link
Member

FYI, v0.8.16 has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Issues with the core library dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants