Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incubator flamechart views from trace server #12

Open
bhufmann opened this issue Mar 19, 2024 · 4 comments
Open

Remove incubator flamechart views from trace server #12

bhufmann opened this issue Mar 19, 2024 · 4 comments

Comments

@bhufmann
Copy link
Contributor

bhufmann commented Mar 19, 2024

With the migration of the incubator flame chart and related views as well as their implementation to mainline Trace Compass eclipse-tracecompass/org.eclipse.tracecompass#9 the trace server will now show 3 different flame chart views (classic, incubator and new) in the available views. As a first step the incubator flamechart plug-in should be removed from the trace server.

Removing the flamechart plug-in will require other incubator plug-ins to remove their dependencies to the incubator flamechart plug-in and use the mainline implementation instead.

Plug-ins to remove from traceserver.product

  • org.eclipse.tracecompass.incubator.callstack.core
  • org.eclipse.tracecompass.incubator.analysis.core

Plug-ins to update (used in trace server)

  • org.eclipse.tracecompass.incubator.rocm.core
  • org.eclipse.tracecompass.incubator.traceevent.core
  • org.eclipse.tracecompass.incubator.traceevent.core.tests

Note: The source code migrated to the mainline Trace Compass should be removed from the incubator repository.

Plug-ins to update after removing the code

  • org.eclipse.tracecompass.incubator.inandout.core
  • org.eclipse.tracecompass.incubator.kernel.core
  • org.eclipse.tracecompass.incubator.tracecompass.core
  • org.eclipse.tracecompass.incubator.uftrace.core
  • org.eclipse.tracecompass.incubator.virtual.machine.analysis.core.tests
  • org.eclipse.tracecompass.incubator.kernel.ui
@MatthewKhouzam
Copy link
Contributor

@arfio Thoughts?

@arfio
Copy link
Contributor

arfio commented Mar 19, 2024

I agree that this should be done after the following pull request is merged:
eclipse-tracecompass/org.eclipse.tracecompass#23
Aside from that:

  • I have updated the ROCm core plugin, I need to push the changes and make a PR for it.
  • The other plugins should follow.

@bhufmann
Copy link
Contributor Author

I noticed that org.eclipse.tracecompass.incubator.callstack.core.sampled.callgraph package hasn't been migrated to mainline. This needs to be done before removing the incubator plug-in.

@arfio
Copy link
Contributor

arfio commented Mar 26, 2024

The org.eclipse.tracecompass.incubator.callstack.core.sampled.callgraph package was added to this PR: eclipse-tracecompass/org.eclipse.tracecompass#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants