Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App/Service Release Process Form -> Agreements & Consents Step -> Translation #937

Open
tfjanjua opened this issue Aug 15, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tfjanjua
Copy link
Contributor

Description

We need translations (especially German) for 'Agreements & Consents' step of App/Service Release Process as we have translations for 'UserRole' and 'CompanyRole' entities.

Acceptance Criteria

We need to add one table into the database with one reference column of Agreement table (as agreementId) and 2 additional columns:

Table name: AgreementDescription
Columns:

  1. AgreementId: Guid
  2. LanguageShortName: string (2)
  3. Description: string

Then, seed data for AgreementDescription table will be added and then this description of agreement will be responded by the APIs:

  • api/apps/AppReleaseProcess/agreementData
  • api/services/serviceRelease/agreementData
    By default these APIs will be returning en values but if param ?languageShortName=de will be added at the end of APIs then the APIs will return German values.

Example:

  • api/apps/AppReleaseProcess/agreementData?languageShortName=de
  • api/services/serviceRelease/agreementData?languageShortName=de

Enhancement of above mentioned APIs will be same as the existing API to get UserRoleDescription

  • api/administration/serviceaccount/user/roles?languageShortName=de

Additional Information

New test will be added and existing tests will be modified accordingly.

@tfjanjua tfjanjua added the enhancement New feature or request label Aug 15, 2024
@tfjanjua tfjanjua self-assigned this Aug 15, 2024
@tfjanjua
Copy link
Contributor Author

Hi @MaximilianHauer | @evegufy | @ybidois
I have added the description for adding translations for the “Agreements and consents” step of the App or Service Release Process as we already have translations for UserRoles and CompanyRoles. Please take a look at these and discuss the requirements so that the development of this improvement can be proceed. Thanks

@MaximilianHauer
Copy link

under evaluation , sorry we are understaffed currently due to holiday season feedback takes a bit

@MaximilianHauer
Copy link

MaximilianHauer commented Sep 18, 2024

@ntruchsess / @Phil91 / @evegufy please take a look and propose your opinion on this

@tfjanjua please provide ACC and Testcases . Example eclipse-tractusx/portal-frontend#1126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: NEW USER REQUEST
Development

No branches or pull requests

2 participants