-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Company Data Unique Identifier - Update Unique Identifier Regex #190
Comments
typecastcloud
added a commit
to Cofinity-X/entry-portal-frontend-registration
that referenced
this issue
Jun 17, 2024
Currently validation for leading and trailing white spaces is not applied. Some patterns do not prevent this type of input. Data causes issues in connected services. Refs: eclipse-tractusx#190
7 tasks
typecastcloud
added a commit
to Cofinity-X/entry-portal-frontend-registration
that referenced
this issue
Jul 9, 2024
Move trimming to onBlur and save. Refs: eclipse-tractusx#190
8 tasks
typecastcloud
added a commit
to Cofinity-X/entry-portal-frontend-registration
that referenced
this issue
Jul 11, 2024
Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern. Refs: eclipse-tractusx#190
6 tasks
shubhamv-ss
pushed a commit
to shubhamv-ss/portal-frontend-registration
that referenced
this issue
Aug 1, 2024
…er error messages (eclipse-tractusx#210) * feat(company data): improved white space handling for company data Move trimming to onBlur and save. Refs: eclipse-tractusx#190 * Update error messages for identifiers. Changes to patterns introduced in PR eclipse-tractusx#196 were not yet included in error messages.
shubhamv-ss
pushed a commit
to shubhamv-ss/portal-frontend-registration
that referenced
this issue
Aug 8, 2024
…er error messages (eclipse-tractusx#210) * feat(company data): improved white space handling for company data Move trimming to onBlur and save. Refs: eclipse-tractusx#190 * Update error messages for identifiers. Changes to patterns introduced in PR eclipse-tractusx#196 were not yet included in error messages.
typecastcloud
added a commit
to Cofinity-X/entry-portal-frontend-registration
that referenced
this issue
Aug 19, 2024
…lect This caused issues when receiving multiple identifier via bpdm. Refs: eclipse-tractusx#190
4 tasks
typecastcloud
added a commit
to Cofinity-X/entry-portal-frontend-registration
that referenced
this issue
Aug 28, 2024
Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern. Refs: eclipse-tractusx#190
story should be enhanced to ensure that furthermore
|
typecastcloud
added a commit
to Cofinity-X/entry-portal-frontend-registration
that referenced
this issue
Sep 18, 2024
Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern. Refs: eclipse-tractusx#190
evegufy
pushed a commit
that referenced
this issue
Sep 20, 2024
* fix(identifiers): allow for shorter and longer german crn Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern. Refs: #190
typecastcloud
added a commit
to Cofinity-X/entry-portal-frontend-registration
that referenced
this issue
Oct 21, 2024
…lect This caused issues when receiving multiple identifier via bpdm. Refs: eclipse-tractusx#190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The current implementation of the regex for the unique identifier worldwide data input allows for spaces at the beginning, the end, as well as multiple spaces in between. This needs to be updated to only allow a single space in between, and not at the start or end of the input.
Implementation to be done under following section: https://github.com/eclipse-tractusx/portal-frontend-registration/blob/main/src/helpers/utils.ts (note this is the open source file - ideally the change is done inside the cofinity repo first and contributed back to open source)
Tasks
Acceptance Criteria
…while implementing the change, please add unit tests
The text was updated successfully, but these errors were encountered: