Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company Data Unique Identifier - Update Unique Identifier Regex #190

Closed
jjeroch opened this issue Jun 16, 2024 · 1 comment
Closed

Company Data Unique Identifier - Update Unique Identifier Regex #190

jjeroch opened this issue Jun 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Jun 16, 2024

Description

The current implementation of the regex for the unique identifier worldwide data input allows for spaces at the beginning, the end, as well as multiple spaces in between. This needs to be updated to only allow a single space in between, and not at the start or end of the input.

Implementation to be done under following section: https://github.com/eclipse-tractusx/portal-frontend-registration/blob/main/src/helpers/utils.ts (note this is the open source file - ideally the change is done inside the cofinity repo first and contributed back to open source)

 

Tasks

  • Review the current regex implementation for the unique identifier input.
  • Update the regex to meet the new requirements:
    • Only allow a single space in between characters
    • Do not allow spaces at the beginning or end of the input
  • Update the frontend code to use the new regex.
  • Thoroughly test the new regex implementation to ensure it works as expected.
  • Document the changes in the codebase and update any relevant documentation.

 

Acceptance Criteria

  • The updated regex only allows a single space in between characters in the unique identifier input.
  • Spaces are not allowed at the beginning or end of the input.
  • The frontend implementation uses the updated regex.
  • All tests pass, and the feature works as expected.
  • Documentation is updated to reflect the changes.

 
…while implementing the change, please add unit tests

@jjeroch jjeroch added the bug Something isn't working label Jun 16, 2024
@jjeroch jjeroch added this to the Release 24.08 milestone Jun 16, 2024
typecastcloud added a commit to Cofinity-X/entry-portal-frontend-registration that referenced this issue Jun 17, 2024
Currently validation for leading and trailing white spaces is not applied. Some patterns do not prevent this type of input. Data causes issues in connected services.

Refs: eclipse-tractusx#190
@typecastcloud typecastcloud self-assigned this Jun 18, 2024
typecastcloud added a commit to Cofinity-X/entry-portal-frontend-registration that referenced this issue Jul 9, 2024
typecastcloud added a commit to Cofinity-X/entry-portal-frontend-registration that referenced this issue Jul 11, 2024
Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern.

Refs: eclipse-tractusx#190
evegufy pushed a commit that referenced this issue Jul 12, 2024
…er error messages (#210)

* feat(company data): improved white space handling for company data

Move trimming to onBlur and save.

Refs: #190

* Update error messages for identifiers.

Changes to patterns introduced in PR #196 were not yet included in error messages.
shubhamv-ss pushed a commit to shubhamv-ss/portal-frontend-registration that referenced this issue Aug 1, 2024
…er error messages (eclipse-tractusx#210)

* feat(company data): improved white space handling for company data

Move trimming to onBlur and save.

Refs: eclipse-tractusx#190

* Update error messages for identifiers.

Changes to patterns introduced in PR eclipse-tractusx#196 were not yet included in error messages.
shubhamv-ss pushed a commit to shubhamv-ss/portal-frontend-registration that referenced this issue Aug 8, 2024
…er error messages (eclipse-tractusx#210)

* feat(company data): improved white space handling for company data

Move trimming to onBlur and save.

Refs: eclipse-tractusx#190

* Update error messages for identifiers.

Changes to patterns introduced in PR eclipse-tractusx#196 were not yet included in error messages.
typecastcloud added a commit to Cofinity-X/entry-portal-frontend-registration that referenced this issue Aug 19, 2024
…lect

This caused issues when receiving multiple identifier via bpdm.

Refs: eclipse-tractusx#190
typecastcloud added a commit to Cofinity-X/entry-portal-frontend-registration that referenced this issue Aug 28, 2024
Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern.

Refs: eclipse-tractusx#190
@MaximilianHauer
Copy link

story should be enhanced to ensure that furthermore

  • only digits are allowed after the initial space
  • Sequence can only start by HRA or HRB

typecastcloud added a commit to Cofinity-X/entry-portal-frontend-registration that referenced this issue Sep 18, 2024
Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern.

Refs: eclipse-tractusx#190
evegufy pushed a commit that referenced this issue Sep 20, 2024
* fix(identifiers): allow for shorter and longer german crn

Some examples of german company registration numbers did not work with old pattern. See 'HRB 42' or 'HRB 209459 B'. Min/max length alligned with worldwide pattern.

Refs: #190
typecastcloud added a commit to Cofinity-X/entry-portal-frontend-registration that referenced this issue Oct 21, 2024
…lect

This caused issues when receiving multiple identifier via bpdm.

Refs: eclipse-tractusx#190
@evegufy evegufy closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants