Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Enhance BPN user link with BPN allowed BPN (validation handling) #989

Open
12 tasks
Phil91 opened this issue Aug 6, 2024 · 1 comment
Open
12 tasks
Assignees
Labels
enhancement New feature or request

Comments

@Phil91
Copy link
Member

Phil91 commented Aug 6, 2024

In the current implementation additional BPNs can get added to user account.

The solution does not verify/support to validate if the BPN is a valid BPN or if this BPN is really correctly added.

With one of the latest BPDM feature enhancements, this is now possible.

Endpoint supported by BPDM: GET /api/catena/legal-entities/\{bpnl}/sites

BPDM Pool Swagger

 

Details of the needed change:


 

FE Page:

"User Management" => "User List" (bottom of the page) => "Details"

Example URL from dev:

[https://portal.dev.demo.catena-x.net/userdetails/92548f6e-21e2-4796-9ad1-21599a3b69d7]

Example Screenshot

image-2024-01-02-13-06-15-714

1 Rework of the overlay

As-is:

image-2024-01-02-13-07-02-731  
  •  Update the overlay (screenshot above) by exchanging the input field with an dropdown field
  • The dropdown should display the BPNs which are responded when calling {GET /api/catena/legal-entities/{bpnl}/sites{color}
  • The user should be able to select multiple BPN(s)
  • Minimum one BPN need to get selected 
  • Instead of "Close" the button on the overlay bottom should be called "Submit"
  • When hovering on the delete icon an tooltip should get displayed
    • de: Die Löschung ist sofort aktiv.
    • en: The deletion is active immediately.
  • The dropdown list which is generated withGET /api/catena/legal-entities/\{bpnl}/sites should not include those BPN(s) which are already assigned to the user
  • If the user clicks the "Submit" button, the endpoint POST /api/administration/user/owncompany/users/\{companyUserId}/businessPartnerNumber is called including all selected BPN(s) of the dropdown field in the request body
  • till the response is available, a load element is displayed
  • on success, the list of BPNs is getting updated and the dropdown list is updated (should not show the previous available BPNs anymore)
  • on failure, the error is getting displayed inside the overlay - please check the error handling in detail. Extended error handling is active/supported. There will be two scenarios
    • all BPNs have failed (system error) => display the error inside the overlay and keep the bpn selection active
    • a couple of BPNs have been successful and just a number of BPNs unsuccessful. In this case extended error response is needed which only displays the error BPN(s)
  • Between the dropdown and the dropdown header/title, a description is needed which is stating the following details
    • de: Die auszuwählenden BPNs richten sich nach den Unternehmenszugehörigen BPNs. Um diese zu ändern/zu erweitern nutzen sie bitte das Partner Pool Management.
    • en: The BPNs to be selected depend on the BPNs belonging to the company. To change/expand these, please use Partner Pool Management.

 

Linked Tickets:

Backend changes will get implemented as part of eclipse-tractusx/portal-backend#901

@Phil91
Copy link
Member Author

Phil91 commented Aug 6, 2024

@MaximilianHauer I've migrated this issue from jira, the backend part was previously assigned to Prasanna

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: BACKLOG
Development

No branches or pull requests

2 participants