Formatting selected code doesn't work anymore, the whole file is formatted instead

[travkin79]

Issue
If you select some text in an LSP-based text editor and then you use the shortcut for formatting code (Ctrl + Shift + F on PCs), then the whole file is formatted instead of formatting the selected text only.

[travkin79]

See

lsp4e/org.eclipse.lsp4e/src/org/eclipse/lsp4e/operations/format/LSPFormatter.java

Lines 58 to 67 in e3404b4

	return executor.computeFirst((w, ls) -> w.getServerCapabilitiesAsync().thenCompose(capabilities -> {
	if (textSelection.getLength() == 0 && isDocumentRangeFormattingSupported(capabilities)
	&& !(isDocumentFormattingSupported(capabilities))) {
	return ls.getTextDocumentService().rangeFormatting(rangeParams)
	.thenApply(edits -> new VersionedEdits(modificationStamp, edits, document));
	} else {
	return ls.getTextDocumentService().formatting(params)
	.thenApply(edits -> new VersionedEdits(modificationStamp, edits, document));
	}
	}));

According to this code, the range parameters (the given text selection) are only used if the LS does not support document formatting and if the text selection has length 0. That does not make sense to me.

It seems the last change on LSPFormatter accidentally changed the conditions.