Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename symbol always opens a dialog #891

Open
akurtakov opened this issue Jan 11, 2024 · 1 comment
Open

Rename symbol always opens a dialog #891

akurtakov opened this issue Jan 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@akurtakov
Copy link
Contributor

It would be nice to have inline editing (note - not asking for linked editing of all references ) so there is no extra dialog opened.

@mickaelistria
Copy link
Contributor

It would probably be even easier to enable linked editing on rename. To do so, instead of

  1. prepareRename
  2. showDialog for newName
  3. call rename to get the edit
  4. apply the edit

we can try

  1. prepareRename
  2. callRename with another name of same length (eg myVariable becomes xxxxxxxxx), get the edit
  3. from the ranges returned in the edit, enable a linked edit in the editor.

@sebthom sebthom added the enhancement New feature or request label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants