-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable http proxy support for mqtt3 #1010
Open
tg892580
wants to merge
1
commit into
eclipse-paho:develop
Choose a base branch
from
tg892580:enable-httpproxy-mqtt3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Guo <[email protected]>
tg892580
force-pushed
the
enable-httpproxy-mqtt3
branch
from
August 15, 2023 20:29
57db393
to
2e7ceb4
Compare
This was referenced Nov 28, 2023
@tg892580 & Others -- This patch has worked in our project, Can you please let me know if and when the patch will be merged for the release? |
I am glad that the patch helps your project.
But I am not sure when the code will be released, we found the Paho code
missing Http proxy support in our project and provided a solution, it is
totally up to the Paho project team to review it and decide if the patch
should be released.
…On Wed, Jan 10, 2024 at 12:03 PM sagarheroor ***@***.***> wrote:
@tg892580 <https://github.com/tg892580> & Others -- This patch has worked
in our project, Can you please let me know if and when the patch will be
merged for the release?
Really appreciate your work on this patch.
—
Reply to this email directly, view it on GitHub
<#1010 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYNGCKXLNUR5ZHGRPTSVOOTYN3X25AVCNFSM6AAAAAA3QLZ7ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVGYZTIMZQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
|
[email protected]> |
No, that must be other person, I never merged any branch yet.
Can you talk to the project admin for help?
Regards
Tony
…On Thu, Jan 11, 2024 at 7:53 PM sagarheroor ***@***.***> wrote:
***@***.***>
@rdasgupt <https://github.com/rdasgupt> -- I see most of the patches are
merged by you.. Can you please help to merge this patch and release new
version of paho library of java
—
Reply to this email directly, view it on GitHub
<#1010 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYNGCKXOXONYIEC4L2S6XPLYOCXT7AVCNFSM6AAAAAA3QLZ7ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYGM4TGMRRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code change allows Paho mqtt3 client which is running behind a http proxy is able to communicate to mqtt broker in outside world.
If the Http Proxy is configured, the new code will establish a TCP tunnel between mqtt client and the http proxy first, so that any further mqtt traffic to the mqtt broker will be routed through the TCP tunnel to the http proxy, which then forwards the traffic to the mqtt broker.
Signed-off-by: Tony Guo [email protected]
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!
used to sign the CLA) Hint: use the -s argument when committing.
you are fixing straight away that you add some Description about the bug and how this will fix it.