Allow configurable hostname lookup #934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtomson
force-pushed
the
pluggable_resolver
branch
4 times, most recently
from
908739f
to
f6681ea
Compare
Signed-off-by: James Tomson <[email protected]>
jtomson
force-pushed
the
pluggable_resolver
branch
from
e1a8b5c
to
e640627
Compare
jtomson
commented
May 31, 2022
| @@ -69,7 +73,13 @@ public void start() throws IOException, MqttException { | |||
| try { | |||
| // @TRACE 252=connect to host {0} port {1} timeout {2} | |||
| log.fine(CLASS_NAME,methodName, "252", new Object[] {host, Integer.valueOf(port), Long.valueOf(conTimeout*1000)}); | |||
| SocketAddress sockaddr = new InetSocketAddress(host, port); | |||
| final SocketAddress sockaddr; | |||
| if (dns != null) { | |||
There was a problem hiding this comment.
This is the only behavior added. The rest of the changes in this PR are plumbing this optional dns interface from the user to this point
|
@rdasgupt is there any appetite for this change? if so I'd be happy to resolve the conflicts thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!
used to sign the CLA) Hint: use the -s argument when committing.
you are fixing straight away that you add some Description about the bug and how this will fix it.
We are using this interface to perform IPv4-only lookups. It may also help those looking for other hostname resolution behavior like #475
If there's interest in merging this I am happy to add javadocs as well as clientv5 modifications