Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Protocol: add a flag on ChangeBoundsAction to distinguish resize vs move #392

Open
CamilleLetavernier opened this issue Oct 10, 2019 · 0 comments
Labels
client A issue that is heavily affecting the client part (Typescript)

Comments

@CamilleLetavernier
Copy link
Collaborator

While resize and move can generally be regrouped in a single "Change Bounds" action, it is sometimes useful to distinguish them, at least in two cases:

  • Sometimes the bounds aren't 100% consistent between the client and the server. If the client sends its own version of the bounds during a Move, the server may interpret the action as a resize instead; so a Move could result in resizing the Node
  • Some nodes may require some special behavior when moving vs resizing (When they don't use a simple X/Y Layout), so it may be useful to distinguish

The client (ResizeTool/MoveTool) should add a flag in the ChangeBoundsAction to indicate the kind of ChangeBoundsAction that should be triggered. On the default server side, there is probably nothing special to do; I don't think such a distinction is necessary for the generic cases.

@CamilleLetavernier CamilleLetavernier added the client A issue that is heavily affecting the client part (Typescript) label Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client A issue that is heavily affecting the client part (Typescript)
Projects
None yet
Development

No branches or pull requests

1 participant