-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using land cover products to quantify urbanisation trends #51
Comments
Hi @inesgirao, Could you please check that you are sharing the workflow ID? (note that workflow ID is different than task ID) |
Hi @malmans2 I am sorry for missing it. Thank you |
OK, no need to change the one used for the first notebook. Here is the permalink: https://github.com/ecmwf-projects/c3s2-eqc-quality-assessment/blob/08cdcb810fdf9e9844064d3a079f54c73b6244d3/Satellite_ECVs/Land_Biosphere_ECVs/satellite_satellite-land-cover_trend-assessment_q02.ipynb Please make sure that the notebook name is correct. If you need to make modifications (e.g., to address the reviewer's comment), please share here the new version of the notebook and I will provide a new permalink. Let me know when the notebook is accepted, I will merge the PR into main. |
Hi @malmans2 I now send the new version of this notebook. Thank you C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_LULC_UQ2_v1.3.zip |
Hi @inesgirao , Small suggestion. I noticed that in a cell you read the NUTS regions from a local file. Because of that, the notebook does not work for external people that would like to try it. You already define the NUTS url, so the fix would be very easy. Next time you request a permalink I suggest to implement this change: - nuts = gpd.read_file('./NUTS_RG_20M_2021_4326.shp')
+ nuts = gpd.read_file(shapefile_url) |
Hello @malmans2 I resend the zip file, with new template. Thank you |
Hello @malmans2 I resend the zip file, with new changes asked by the data provider. Ps. I had some changes in my environment, where should i re-upload it? Thank you C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_LULC_UQ2_v1.5.zip |
Hi @inesgirao, This issue was opened a long time ago and it looks like you did not share the correct workflow ID. It should be clearly shown in the CIM. |
Hey, I am sorry. Workflow: eqctier3-e30af9a0-46df-4eb8-ae78-35519b70b8d4 Thank you |
Hi @inesgirao, There are a few issues you need to address:
The first point is the most important, so please focus on that and send me the revised version of your notebook. If anything is unclear with points 2, 3, or 4, I can help fix them. |
C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_LULC_UQ2_v1.5.zip Hey @malmans2 Here it goes, hopefully, everything is now proper. Thank you |
Looks good now! Please ensure that the notebook name is correct. If you need to make any modifications (e.g., addressing the reviewer's comments), please share the new version of the notebook here, and I will provide a new permalink. Let me know once the notebook is accepted, and I will merge the PR into the main branch. |
Hello @malmans2 I resend the zip file, with new changes asked by the data provider. Thank you C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_LULC_UQ2_v1.7.zip |
Hi @inesgirao, I had to make various changes to the notebook. Here is the list:
Please have a look to the notebook template and instructions as these problems are quite common in your group. I will release the permalink in a minute. |
Hey @malmans2, I apologise for the back and foward but i notice some small but necessary changes were needed so I resend the file. I followed your guidelines and I believe is fully ready for a permalink, C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_LULC_UQ2_v1.7.zip Thank you for you support! |
Dear @malmans2, I wanted to confirm if it’s acceptable that the BOPEN functions have not been implemented in this JN. I ask because they were in the JN for the FIRE dataset. Since you’ve already reviewed this, I want to ensure that proceeding without these functions won’t cause any issues down the line. Thank you very much for your time and guidance. |
When evaluators contact us through the template repository, we provide support and review or optimise code when needed. However, to my knowledge, there are no constraints on the code you submit here. In fact, I only provide permalinks in this repository and do not review the code. |
If I am not mistaken this JN went througth the template repository before but its true that I did not ask specifically to implement BOPEN functions. My question is more if this is ok, or the notebook needs to be revised to include the BOPEN functions. Thank you for the feeback. |
I'm not sure I am following. B-Open software is imported. Which B-Open functions you are not using? |
Per example, I use my own code for cell area calculation. |
That's not an issue as long as you are confident that the code produces correct results. We only provide technical support and do not have knowledge or understanding of the science behind all notebooks (e.g., I do not know how you obtained the scaling factors for computing the cell area, but it's not my job to check that). B-Open reviewed the technical side of the code, and I can confirm that it's well written and runs smoothly, so no need to change anything if the results are correct. |
Ok, thank you for your clarifications |
Data Type
Satellite ECVs - Land Biosphere
Assessment Category
Trend Assessment
Dataset Name
satellite-land-cover
Question Number
2
Workflow ID
eqctier3-e30af9a0-46df-4eb8-ae78-35519b70b8d4
Zipped Notebook
C3S2_D520.5.3.14b_Quality_Assessment_User_Questions_LULC_UQ2_v1.3.zip
Environment
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: