Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to binary protocol v2.0 #336

Closed
ifiokjr opened this issue Aug 26, 2024 · 2 comments
Closed

Upgrade to binary protocol v2.0 #336

ifiokjr opened this issue Aug 26, 2024 · 2 comments

Comments

@ifiokjr
Copy link
Contributor

ifiokjr commented Aug 26, 2024

Description

Currently, edgedb-protocol uses the binary protocol 1.0.

For my current project edgedb_codegen I would like access to the enum name for autogenerating shared types and better type checking.

This is available in the binary protocol version 2.0: https://docs.edgedb.com/database/reference/protocol/typedesc.

This can either be as a breaking release or adding the ability to support both protocol versions.

@tiberiusferreira
Copy link

tiberiusferreira commented Dec 17, 2024

Hey, this might already be the case now. @ifiokjr , I added standalone transactions to this fork , then had to fork you repo too: fork to keep using it.

In the process I had to update it too and there were some new protocol entities.

@aljazerzen
Copy link
Contributor

Yes, this has already been implemented.

Closed by #354

(and #360)

And let's open a new issue about "standalone transactions".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants