Issue 41 #49
Issue 41 #49
Conversation
Signed-off-by: Joseph Pearson <[email protected]>
Signed-off-by: Joseph Pearson <[email protected]>
|
|
||
| || Property | Value | ||
| | description | EdgeX Foundry service without devices | ||
| | sharable | singleton |
There was a problem hiding this comment.
Do we definitely need this service to be singleton? Same comment for the device service def below,
| If all goes well and there were no typos, you should see output similar to the following: | ||
|
|
||
| ``` | ||
| New dependency created: url: com.github.joewxboy.horizon.edgex.core, org: testorg, version: [1.0.2,INFINITY), arch: amd64 . |
There was a problem hiding this comment.
Is this msg right? I thought this msg only comes out for hzn dev dependency new, which I dont see you doing in these instructions? Maybe you forgot to add instructions for the new dependency.
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
I think I understand why you are adding all of these files to source control, but usually when we do that, it's a good idea to provide defaults for this file so that folks can just run the example out of the repo. Can we do that in this case? if not, then the value of source controlling these files is somewhat limited. In that case, maybe only source control the example service def file?
added configuration subdirectories for new
coreanddeviceservices, and documentation detailing how to create, test, and publish those new services. This completely separates the Random Integer Device Service from the Edge Foundry Core set of Services.This PR should address the first half of #41 which is separating the Device Service from the Core.