Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech-Debt] Refactor the repeated blocks in compose-builder/makefile to use script or function #284

Open
jim-wang-intel opened this issue Sep 8, 2022 · 1 comment
Open

[Tech-Debt] Refactor the repeated blocks in compose-builder/makefile to use script or function #284

jim-wang-intel opened this issue Sep 8, 2022 · 1 comment
Assignees
@lenny-goodell
Labels
1-low priority denoting isolated changes hold Intended for PRs we want to flag for ongoing review tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds

Comments

@jim-wang-intel
Copy link
Contributor

jim-wang-intel commented Sep 8, 2022 •
edited by lenny-goodell
Loading

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for Makefile of docker-compose

Description [REQUIRED]

A clear and concise description of the problem or missing capability...

To reduce the clutter of makefile, refactor similar repeated code into shell script or makefile function.

Describe the solution you'd like

If you have a solution in mind, please describe it.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?
@jim-wang-intel jim-wang-intel added 1-low priority denoting isolated changes tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds labels Sep 8, 2022
@lenny-goodell lenny-goodell changed the title [Tech-Debt] Refactor the knowSecrets in compose-builder/makefile to use script or function [Tech-Debt] Refactor the repeated blocks in compose-builder/makefile to use script or function Aug 16, 2023
@lenny-goodell lenny-goodell mentioned this issue Aug 16, 2023
Merged
3 tasks
@lenny-goodell lenny-goodell added the hold Intended for PRs we want to flag for ongoing review label Aug 16, 2023
@lenny-goodell
Copy link
Member

On hold until after 31. release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-goodell lenny-goodell

Labels
1-low priority denoting isolated changes hold Intended for PRs we want to flag for ongoing review tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
Technical WG
Status: Icebox
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jim-wang-intel @lenny-goodell