do not indent leaf tag. #26
Conversation
When indenting tags in the form (:tag "content") are printed like this: <tag>content</tag> instead of: <tag>content </tag>
|
Maybe this should be optional... |
|
Maybe it should depend on how long "content" is? |
|
Stas Boukarev <[email protected]> writes:
Maybe it should depend on how long "content" is?
Yes good idea. I'll try to come up with this addition.
--
Manuel Giraud
|
This work for static content only. Not for computed content as: ``` (let ((str (make-string 200 :initial-element #\a))) (:tag (who:str str))) ```
|
Stas Boukarev <[email protected]> writes:
Maybe it should depend on how long "content" is?
Ok, I've just add a patch on this same pull request that does that.
--
Manuel Giraud
|
|
Hi, |
|
This is a low priority enhancement, I'll look at it when I have time. |
|
Ok, I understand that. Get back to sbcl ;-) |
| @@ -120,6 +120,9 @@ in *HTML-EMPTY-TAGS* as <tag/> \(XHTML mode) or <tag> \(SGML | |||
| mode and HTML5 mode). For all other tags, it will always generate | |||
| <tag></tag>.") | |||
|
|
|||
| (defvar *short-leaf-content-length* 72 | |||
| "Below this threshold leaf tags won't be indented.") | |||
There was a problem hiding this comment.
This docstring is unclear in that it doesn't specify units. I'd much prefer something like "Leaf tags shorter than this many characters won't be indented."
There was a problem hiding this comment.
Wow, old stuff! Yes fine by me. Having units is better. I'm also ok with your other comments… but now I should find out how to modify the patch for this PR :-|
| a list of strings or Lisp forms. LEAF-P is t when the TAG is a leaf | ||
| and is not indented.")) | ||
| a list of strings or Lisp forms. SHORT-LEAF-P is t when the TAG is a | ||
| leaf and its content is shorter than *SHORT-LEAF-CONTENT-LENGTH* then |
There was a problem hiding this comment.
Again, specifying that this is in characters would be useful. Also, the grammar here irks me.
"[...] is t when TAG is a leaf and its content is shorter than SHORT-LEAF-CONTENT-LENGTH characters. Short leaves are not indented."
|
|
||
| (defmethod convert-tag-to-string-list (tag attr-list body body-fn leaf-p) | ||
| (defmethod convert-tag-to-string-list (tag attr-list body body-fn short-leaf-p) |
There was a problem hiding this comment.
This is an awful lot of required params. Could some of these be &key args?
| (< (loop for e in (rest s) when (stringp e) sum (length e)) | ||
| *short-leaf-content-length*)))) | ||
| (let (tag attr-list body) | ||
| (cond |
When indenting, tags in the form
(:tag "content")are printed likethis:
<tag>content</tag>instead of: