Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-request broken in LispWorks 8 #124

Open
erikronstrom opened this issue Aug 2, 2022 · 6 comments
Open

http-request broken in LispWorks 8 #124

erikronstrom opened this issue Aug 2, 2022 · 6 comments

Comments

@erikronstrom
Copy link

2.0.8 works in LispWorks 8 but 2.0.9 doesn't. The problem was introduced in commit 5f6962c

This quote from the LispWorks documentation describes the situation pretty accurately:

Code using new LispWorks functionality should be conditionalized only using features representing earlier versions, so as to future-proof your code:

(defvar *feature-added-in-LispWorks-8.0*
  #+(or lispworks4 lispworks5 lispworks6 lispworks7) nil
  #-(or lispworks4 lispworks5 lispworks6 lispworks7) t)

This is because a feature added in LispWorks 8.0 will generally also be in LispWorks 8.1, LispWorks 9.0 and all later versions.

[...]

We have seen several problematic examples like this:

(defvar *feature-added-in-LispWorks-6.0*
  #+lispworks6 t
  #-lispworks6 nil)

which breaks in LispWorks 7.0, because that release does not contain the :lispworks6 feature.

@fiddlerwoaroof
Copy link

I just ran into this issue with LW8 and managed to work around it by adding (or :lispworks7.1 :lispworks8) wherever there was a lispworks7.1 reader conditional.

@Yehouda
Copy link

Yehouda commented Oct 27, 2023

Changing to :lispworks (without a version) is even better. It is not going to work on earlier versions of LispWorks anyway.

@mdbergmann
Copy link
Contributor

Does this have impact on http over ssl?
Other than that Drakma works fine on Lispworks 8

@Yehouda
Copy link

Yehouda commented Jan 19, 2024

Without SSL it changes the way it works in LispWorks, but still works ok.
With SSL it breaks because the underlying code that it uses to support SSL (CL+SSL) is no working properly on LispWorks.

@mdbergmann
Copy link
Contributor

Alright. Is there a PR that fixes it?

@Yehouda
Copy link

Yehouda commented Jan 19, 2024

I don't actually make changes on github, but there are two PRs that fix it in the "Pull requests" tab.
The one by tfiala looks better #129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants