Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use last element of uri path in the default cookie path value #87

Open
zellerin opened this issue Oct 28, 2017 · 0 comments
Open

Comments

@zellerin
Copy link
Contributor

zellerin commented Oct 28, 2017

In get-cookies in cookies.lisp, the :path for cookie is set to

(or (parameter-value "path" parameters)
   (puri:uri-path uri)
    "/")

This differs from RFC, https://tools.ietf.org/html/rfc6265#section-5.1.4, and practically, it breaks some applications (e.g., if cookie is set in /app/login, path is set to /app/login, not to /app, and rest of application does not receive it.)

Using (puri:uri-path (puri:merge-uris "." uri)) would help my use case, but I am not sure that this is in general exactly the same.

I can pull the one-line patch with this if wanted (docs and test cases as well?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant